When creating a node with the makemeeting field, if you do not remove the default date (which defaults to tomorrow), you cannot remove it in subsequent edits and therefore cannot hide the poll from displaying. Even when no one has submitted a response this happens. Shouldn't the field default to nothing? Now that there are no defaults at the field setting screen, shouldn't it just not add any? At least having this as an option would be nice. We have attached the makemeeting field to an event/meeting content type with the hopes that it will help assist with scheduling meetings, when needed. But most of the times it won't be required.

To reproduce:

  1. Create new node with makemeeting field.
  2. Do NOT remove the default date/suggestion which always defaults to the following day.
  3. Save node.
  4. Edit node and attempt to remove the date suggestion.

Also, I noticed the following error in my site around the time I was performing these activities. Not 100% sure whether it's related.

Notice: Undefined index: field_schedule_meeting in makemeeting_field_widget_form() (line 253 of /path/to/makemeeting/makemeeting.module).

Comments

SebCorbin’s picture

SebCorbin commented
Status: Active » Fixed

Just pushed a fix, hope it solves it :)

timwood’s picture

timwood
Primary language English
Location Rockville, Maryland
commented
Status: Fixed » Needs work

SebCorbin,
Thanks for getting to this so quickly! Unfortunately the commit, which I grabbed as a patch at http://drupalcode.org/project/makemeeting.git/patch/9fad7b6 and applied to the 7.x-2.0-rc4 version, does not fix the issue I'm experiencing. I still cannot remove all choices from the makemeeting in from an existing node. I tried on a fresh Drupal install after applying the patch.

Also, should I open a feature request to add a field level setting to disable the default choice? Is this even something you would consider?

Thanks!

SebCorbin’s picture

SebCorbin commented
Status: Needs work » Fixed

Yup, sorry I did that a little bit too quickly... That's fixed

As for the default choice, I tried to make the widget default_value-aware but failed, so I disabled the default value widget form.
Why? Because dates are pretty moving, there's no point to have a default date from 3 months ago. PLus apparently that was confusing some users, see #1960602: Remove button choices when managing MakeMeeting field. Maybe a variable should do the trick?

timwood’s picture

timwood
Primary language English
Location Rockville, Maryland
commented

I think a per entity/content type variable available on the field settings screen would work. Then I could export that to a feature with my content type. Although when setting a configuration on the field setting screen, typically I would expect that to export with the field array instead of having to include an additional variable.

I'll test the new fix shortly.

timwood’s picture

timwood
Primary language English
Location Rockville, Maryland
commented

The latest fix works great for the removing the choice problem. Thanks again!

SebCorbin’s picture

SebCorbin commented

You might want to check this :) #1974536: Add a setting for the default number of dates to display

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.