Use webform_submission_delete so uploaded files are deleted as well

Files can be attached to the email if you use the mimemail module.

I need the NoSave option because of legal issues; I'm not allowed to keep submission data on the web server. If this module claims to stop Webform from storing submissions, I expect it to do delete everything. It's up to the site builder to make sure the submitted data is sent somewhere else - after all he must also configure the email settings.

I'm just looking at the code right now (my machine with all the running code is at work), but if I understand correctly:

Webform module is checking if the mimemail module is enabled in the webform_email_html_capable() function in webform.module. If mimemail is enabled, webform is able to send HTML emails and/or add attachments to the emails. For each email that is defined for a webform, settings are saved in $node->webform['emails'][$eid]. Looking at line 274 of webform.submissions.inc, I see that the setting that uploads must be sent as attachment, is in $node->webform['emails'][$eid]['attachments']. So, if any of the defined emails has the 'attachments' value set to 1, you can delete the uploaded files.

BTW this is all based on webform 7.x-4.0-alpha6, I didn't check if other versions are different.

Sounds fair, but we may be missing a possible use case here. Suppose I have a webform which sends out two e-mails - one with attachments and one without - but I still want the mail receiver without the attachments to be able to download the files. That would not be possible in the suggested workflow, right?

Maybe it would be better to add a second checkbox to the webform_configure_form, which is only available if mimemail is enabled AND the nosave checkbox is selected. Code could look something like this (disclaimer: untested code!):

      $form['advanced']['nosave_attachments'] = array(
        '#type' => 'checkbox',
        '#title' => t('Also delete submitted files from disk'),
        '#description' => t('Check here, if you do not want to store uploaded files on disk. Make sure to add the files to one or more e-mails as attachment.'),
        '#default_value' => $nosave_attachments,
        '#access' => webform_email_html_capable(),
        '#states' => array(
          'visible' => array(
            ':input[name="nosave"]' => array('checked' => TRUE),
          ),
        ),
      );

The value (0 or 1) of nosave_attachments could be stored in a second column in the webform_nosave table. In webform_nosave_delete_result() you would select both the nid and the nosave_attachment value from the database and perform the desired action.

Thanks, I was away for the weekend, I'll try to test it tomorrow.