After upgrading to 7.x-1.x-dev or 7.x-1.9-rc1 versions, the wrappers previously assigned do not get added to the menu.

Comments

michaelgiaimo’s picture

I can verify this. Had some included in the "Around the hyperlinks" field that aren't working now. Incidentally, the HTML that I have in the "Around the hyperlinks content" field IS still working.

mehrpadin’s picture

Status: Needs review » Fixed

Hey everybody,

Fixed, thanks a lot! please keep finding bugs :)

luca cattaneo’s picture

Hi!
same error on 7.x-1.9.
I installed the 7.x-1.x-dev and it's ok.
thanks!

acidb’s picture

Hello,
for me it didn't work. After changing this, it worked for me too:

index 19793fb..a5285a1 100644
--- a/superfish.module
+++ b/superfish.module
@@ -1948,11 +1948,11 @@ function theme_superfish_build($variables) {
         }
         $output['content'] .= isset($whl[1]) ? $whl[1] : '';
         $output['content'] .= ($megamenu_wrapper) ? '<ul class="sf-megamenu"><li class="sf-megamenu-wrapper ' . $item_class . '">' : '';
-        $output['content'] .= ($show_children) ? (($megamenu_content) ? '<ol>' : '<ul>') : '';
         $output['content'] .= ($show_children) ? (isset($wul[0]) ? $wul[0] : '') : '';
+        $output['content'] .= ($show_children) ? (($megamenu_content) ? '<ol>' : '<ul>') : '';
         $output['content'] .= ($show_children) ? $children['content'] : '';
-        $output['content'] .= ($show_children) ? (isset($wul[1]) ? $wul[1] : '') : '';
         $output['content'] .= ($show_children) ? (($megamenu_content) ? '</ol>' : '</ul>') : '';
+        $output['content'] .= ($show_children) ? (isset($wul[1]) ? $wul[1] : '') : '';
         $output['content'] .= ($megamenu_wrapper) ? '</li></ul>' : '';
         $output['content'] .= ($megamenu_column) ? '</div>' : '';
         $output['content'] .= '</li>';
@@ -1980,11 +1980,11 @@ function theme_superfish_menu_item($variables) {
   $sub_menu = '';
 
   if ($element['below']) {
-    $sub_menu .= ($properties['megamenu']['megamenu_content']) ? '<ol>' : '<ul>';
     $sub_menu .= isset($properties['wrapper']['wul'][0]) ? $properties['wrapper']['wul'][0] : '';
+    $sub_menu .= ($properties['megamenu']['megamenu_content']) ? '<ol>' : '<ul>';
     $sub_menu .= $element['below'];
-    $sub_menu .= isset($properties['wrapper']['wul'][1]) ? $properties['wrapper']['wul'][1] : '';
     $sub_menu .= ($properties['megamenu']['megamenu_content']) ? '</ol>' : '</ul>';
+    $sub_menu .= isset($properties['wrapper']['wul'][1]) ? $properties['wrapper']['wul'][1] : '';
   }
 
   $output = '<li' . drupal_attributes($element['attributes']) . '>';
@@ -2023,4 +2023,4 @@ function theme_superfish_menu_item_link($variables) {
   $menu_item = $variables['menu_item'];
   $link_options = $variables['link_options'];
   return l($menu_item['link']['title'], $menu_item['link']['href'], $link_options);
-}
\ No newline at end of file
+}

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.