Cancel button broken redirect url [#1973904]

When editing a file the cancel button does not redirect properly. Destination path should be formatted. Now it is redirecting to /admin/content/file/thumbnails%3Ffolder%3D1. We should set $form_state['redirect'] an array with path and query, not the path string.

Comment	File	Size	Author
#2	media_browser_plus-cancel_button_redirect-1973904-1.patch	588 bytes	boychev
#1	media_browser_plus-cancel_button_redirect-1973904-0.patch	586 bytes	boychev

Comments

Comment #1

boychev commented 18 April 2013 at 15:01

Status:

Active

» Needs review

Status	File	Size
new	media_browser_plus-cancel_button_redirect-1973904-0.patch	586 bytes

Here is my patch that fixes the cancel button redirect.

Comment #2

boychev commented 19 April 2013 at 07:43

Status	File	Size
new	media_browser_plus-cancel_button_redirect-1973904-1.patch	588 bytes

The above patch has a mistake. Here is the correct patch.

Comment #3

das-peter commented 19 April 2013 at 08:11

Thanks, looks reasonable: applied, committed and pushed: http://drupalcode.org/project/media_browser_plus.git/commit/d1d96d9

@boychev Maybe you should check your profile, your git attribution code --author="git <git@853374.no-reply.drupal.org>" doesn't contain your username and I don't manually adjust what I copy from there to avoid making a mess ;)