There is no reason why we would not allow the search block to not be suppressed on the core search page.

CommentFileSizeAuthor
#6 1974076-6.patch1.89 KBpwolanin
#4 1974076-2.patch1.87 KBnick_vh
#2 1974076-1.patch1.84 KBnick_vh
#1 1974058-1.patch541 bytesnick_vh

Comments

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Active » Needs review
StatusFileSize
new 1974058-1.patch541 bytes
nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
StatusFileSize
new 1974076-1.patch1.84 KB

Wrong patch

pwolanin’s picture

pwolanin commented
Status: Needs review » Needs work

what's the motivation?

Also, this variable being passed into t() should have a better name:

!core_search_text"', $t_args),

and the patch makes it impossible to translate this fragment:

% will be replaced by the value of % in the path
nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs work » Needs review
StatusFileSize
new 1974076-2.patch1.87 KB

Motivation is to allow to surpress the search box of every search page, not just from any other page except core search page. I don't see any reason why we would want to block that.

pwolanin’s picture

pwolanin commented
Status: Needs review » Needs work

we shouldn't break existing translations

pwolanin’s picture

pwolanin commented
Status: Needs work » Needs review
StatusFileSize
new 1974076-6.patch1.89 KB
nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs review » Reviewed & tested by the community

looks good

pwolanin’s picture

pwolanin commented
Status: Reviewed & tested by the community » Fixed

fixed for 7 and 6.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.