Closed (fixed)
Project:
Commerce Card on File
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Apr 2013 at 00:17 UTC
Updated:
6 May 2013 at 14:30 UTC
The rules events are incorrect.
Lines 1312-1317 of commerce_cardonfile.module:
if (empty($response) || empty($response['status'])) {
rules_invoke_all('commerce_cardonfile_charge_failed', $card_chosen, $order, $charge, $response);
}
else {
rules_invoke_all('commerce_cardonfile_charge_success', $card_chosen, $order, $charge, $response);
}
Corresponding rules events in commerce_cardonfile.rules.inc lines 92 and 116:
$events['commerce_cardonfile_order_charge_failed'] = array(...
...
$events['commerce_cardonfile_order_charge_success'] = array(...
Attached is a patch that changes the rules events to match the patterns of the other events.
$events['commerce_cardonfile_charge_failed'] = array(...
...
$events['commerce_cardonfile_charge_success'] = array(...
| Comment | File | Size | Author |
|---|---|---|---|
| commerce-cardonfile-rules-events.patch | 918 bytes | chertzog |
Comments
Comment #1
dwkitchen commentedThanks for spotting that one. Committed