The rules events are incorrect.

Lines 1312-1317 of commerce_cardonfile.module:


  if (empty($response) || empty($response['status'])) {
    rules_invoke_all('commerce_cardonfile_charge_failed', $card_chosen, $order, $charge, $response);
  }
  else {
    rules_invoke_all('commerce_cardonfile_charge_success', $card_chosen, $order, $charge, $response);
  }

Corresponding rules events in commerce_cardonfile.rules.inc lines 92 and 116:

  $events['commerce_cardonfile_order_charge_failed'] = array(...
...
  $events['commerce_cardonfile_order_charge_success'] = array(...

Attached is a patch that changes the rules events to match the patterns of the other events.

  $events['commerce_cardonfile_charge_failed'] = array(...
...
  $events['commerce_cardonfile_charge_success'] = array(...
CommentFileSizeAuthor
commerce-cardonfile-rules-events.patch918 byteschertzog

Comments

dwkitchen’s picture

Status: Needs review » Fixed

Thanks for spotting that one. Committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.