Fix TODO:

// TODO:
// Implement hook_taxonomy to delete subqueues when terms are deleted.
// And to update titles when taxonomy terms are changed.
...
// Since this is a relatively rare operation, and I'm out of time for this
// project, I'm leaving this for some enterprising developer who needs this.

Well, I need this. Here ya go. I fixed a couple of typos as well as an, uh, interesting bug in nodequeue_subqueue_update_title(). (I don't think renaming *everything* was the intention.)

CommentFileSizeAuthor
nodequeue-taxonomy-fixes.patch3.52 KBbdragon

Comments

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Committed! Thanks very much!

moshe weitzman’s picture

moshe weitzman commented
Title: Implement taxonomy hook (as per TODO) » Implement taxonomy hook (for term inserts)
Status: Fixed » Active

seems like we should add operations when terms are added as well. the smartqueue_taxonomy module needs to know this. i recall seeing some code that attempts to discover new terms after they are added but i am not seeing that working ATM

merlinofchaos’s picture

merlinofchaos commented
Status: Active » Fixed

The smartqueue_taxonomy module doesn't care if terms exist, it only cares if terms are in use; it's meant to improve efficiency. As such, it doesn't need to react to terms being added. It'll auto-create a queue when it sees a node with the proper term.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.