I don't know if this is an issue with workflow or workflow_fields, but workflow (latest dev) breaks workflow fields, and I am unable to edit any specific workflow, as i get a "The website encountered an unexpected error. Please try again later." If i disable workflow_fields everything works ok.

I have submitted this as an issue to workflow fields here: https://drupal.org/node/1974602

Comments

nancydru’s picture

That sounds like WF is not keeping up with Workflow's changes. Are they even working on the 7.x branch? I have been working with the Workflow Extensions guy so that he's up to date.

However, my first suggestion is to go back to PHP 5.3. There are many known Drupal issues with 5.4.

rdeboer’s picture

Title: Workflow 1.1 breaks workflow fields » Workflow 1.1 breaks Workflow Fields and the Views in Workflow Extensions

Hi, it's the Workflow Extensions guy here...

The Workflow Extenstion Views, /workflow-dashboard and /workflow-history are broken when used with the latest Workflow 7.x-1.x-dev branch. They partly show, but with columns missing. There are no error messages.

First I thought it might be due to the recent Views 3.7, but after trying older versions of Views there was no improvement.

Switching back to Workflow 7.x-1.1 the Workflow Extensions Views come back to live and work with Views. 3.5, 3.6 and 3.7. However 7.x-1.1 has this error message on most pages:

Strict warning: Only variables should be passed by reference in workflow_get_workflow_states_by_sid()
(line 1334 of /Applications/drupal7/sites/all/modules/workflow/workflow.module).

Rik

nancydru’s picture

That last issue has been fixed. I'll take a look, but I am not a Views coder.

Maybe #1961156: Missing translations for states in views?

nancydru’s picture

I am seeing Broken handler workflow_node_history.edit_comment, but I am at a loss to see what the issue is.

k.skarlatos’s picture

Well workflow_fields seems pretty dead right now, nothing has happened for tens of weeks :(

rdeboer’s picture

Title: Workflow 1.1 breaks Workflow Fields and the Views in Workflow Extensions » Workflow 7.x-1.x-dev breaks Workflow Fields and the Views in Workflow Extensions

FYI,
These are the errors I'm getting when visiting /workflow-dashboard. The third column which is supposed to hold the state transition forms is blank.

Warning: call_user_func_array() expects parameter 1 to be a valid callback, class 'workflow_tab_form' not found indrupal_retrieve_form() (line 798 of /Applications/drupal7/includes/form.inc).
Notice: Array to string conversion in drupal_prepare_form() (line 1048 of /Applications/drupal7/includes/form.inc).
Notice: Array to string conversion in drupal_prepare_form() (line 1062 of /Applications/drupal7/includes/form.inc).
Notice: Array to string conversion in drupal_prepare_form() (line 1082 of /Applications/drupal7/includes/form.inc).
Warning: array_key_exists(): The first argument should be either a string or an integer in ThemeRegistry->offsetExists() (line 419 of/Applications/drupal7/includes/theme.inc).
Warning: array_key_exists(): The first argument should be either a string or an integer in ThemeRegistry->offsetExists() (line 419 of/Applications/drupal7/includes/theme.inc).
Warning: strrpos() expects parameter 1 to be string, array given in theme() (line 1023 of /Applications/drupal7/includes/theme.inc).
Warning: array_key_exists(): The first argument should be either a string or an integer in ThemeRegistry->offsetExists() (line 419 of/Applications/drupal7/includes/theme.inc).

I can't make sense of it.
I've done a registry_rebuild, update.php and cleared caches to no avail.

nancydru’s picture

Well, when there are a bunch of errors, I usually concentrate on the first one as that is often the cause of the later ones. In this case, we may be back to the need to pull workflow_tab_form back into the main module as much as we don't want to.

nancydru’s picture

Component: Code » Views
Status: Active » Postponed (maintainer needs more info)

Do we have any Views coders in the house?

rdeboer’s picture

@NancyDru, #8
Is Views the culprit though?

nancydru’s picture

I don't know absolutely, but I am so lost going into Views code that I can't tell.

nancydru’s picture

I believe this is fixed by #1979562: 'workflow_tab_form' not found, which has been committed to Workflow. It may require minor changes to other modules.

nancydru’s picture

Status: Postponed (maintainer needs more info) » Fixed
k.skarlatos’s picture

Well at least the workflow fields part is not fixed, i still get the same error.

May 23 10:11:31 vserver drupal: http://192.168.0.3:83|1369293091|php|192.168.0.29|http://192.168.0.3:83/admin/config/workflow/workflow|http://192.168.0.3:83/admin/config/workflow|1||Warning: Missing argument 2 for workflow_fields_workflow_operations() in workflow_fields_workflow_operations() (line 424 of /srv/http/epik3/sites/all/modules/workflow_fields/workflow_fields.module).
nancydru’s picture

I don't recall any changes to hook_workflow_operations() in a while. At any rate, the Workflow Fields module is supported by someone else. You'll need to post over there.

nancydru’s picture

In double checking, I noticed that the "top actions" call did not include a second parameter, so I added NULL there.

k.skarlatos’s picture

I checked with your latest change applied and it does not fix my problem.

I know it is a problem with the other module, but i think it is abandoned... :(

nancydru’s picture

I couldn't even get it to not break Workflow.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

m42’s picture

Status: Closed (fixed) » Needs review

Sorry for re-opening this issue, but I wanted to tell everybody this would interest that I made a patch so that Workflow Fields should be compatible with latest releases of Workflow.

What I need now are testers and reviewers.
Any comment is welcome but, not to pollute this thread, let's do it in the appropriate page (where the patch is): #2057599: Patch to make Workflow Fields compatible with latest Workflow release (1.2)

Thank you very much for your help !

m42’s picture

Assigned: Unassigned » m42
k.skarlatos’s picture

thanks for the update, i will test and report back!

m42’s picture

Component: Views » Code
Status: Needs review » Fixed

Ladies and gentlemen, we're very proud to give to you the new beta1 release for D7 of the Workflow Fields module.

With many other corrections and improvements, this release makes Workflow Fields now compatible with Workflow 1.2.

That's it folks, now your reviews are welcome on the dedicated project page ! :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.