Closed (fixed)
Project:
Workflow
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
19 Apr 2013 at 10:06 UTC
Updated:
6 Sep 2013 at 12:11 UTC
I don't know if this is an issue with workflow or workflow_fields, but workflow (latest dev) breaks workflow fields, and I am unable to edit any specific workflow, as i get a "The website encountered an unexpected error. Please try again later." If i disable workflow_fields everything works ok.
I have submitted this as an issue to workflow fields here: https://drupal.org/node/1974602
Comments
Comment #1
nancydruThat sounds like WF is not keeping up with Workflow's changes. Are they even working on the 7.x branch? I have been working with the Workflow Extensions guy so that he's up to date.
However, my first suggestion is to go back to PHP 5.3. There are many known Drupal issues with 5.4.
Comment #2
rdeboerHi, it's the Workflow Extensions guy here...
The Workflow Extenstion Views, /workflow-dashboard and /workflow-history are broken when used with the latest Workflow 7.x-1.x-dev branch. They partly show, but with columns missing. There are no error messages.
First I thought it might be due to the recent Views 3.7, but after trying older versions of Views there was no improvement.
Switching back to Workflow 7.x-1.1 the Workflow Extensions Views come back to live and work with Views. 3.5, 3.6 and 3.7. However 7.x-1.1 has this error message on most pages:
Strict warning: Only variables should be passed by reference in workflow_get_workflow_states_by_sid()
(line 1334 of /Applications/drupal7/sites/all/modules/workflow/workflow.module).
Rik
Comment #3
nancydruThat last issue has been fixed. I'll take a look, but I am not a Views coder.
Maybe #1961156: Missing translations for states in views?
Comment #4
nancydruI am seeing
Broken handler workflow_node_history.edit_comment, but I am at a loss to see what the issue is.Comment #5
k.skarlatos commentedWell workflow_fields seems pretty dead right now, nothing has happened for tens of weeks :(
Comment #6
rdeboerFYI,
These are the errors I'm getting when visiting /workflow-dashboard. The third column which is supposed to hold the state transition forms is blank.
I can't make sense of it.
I've done a registry_rebuild, update.php and cleared caches to no avail.
Comment #7
nancydruWell, when there are a bunch of errors, I usually concentrate on the first one as that is often the cause of the later ones. In this case, we may be back to the need to pull workflow_tab_form back into the main module as much as we don't want to.
Comment #8
nancydruDo we have any Views coders in the house?
Comment #9
rdeboer@NancyDru, #8
Is Views the culprit though?
Comment #10
nancydruI don't know absolutely, but I am so lost going into Views code that I can't tell.
Comment #11
nancydruI believe this is fixed by #1979562: 'workflow_tab_form' not found, which has been committed to Workflow. It may require minor changes to other modules.
Comment #12
nancydruComment #13
k.skarlatos commentedWell at least the workflow fields part is not fixed, i still get the same error.
Comment #14
nancydruI don't recall any changes to hook_workflow_operations() in a while. At any rate, the Workflow Fields module is supported by someone else. You'll need to post over there.
Comment #15
nancydruIn double checking, I noticed that the "top actions" call did not include a second parameter, so I added NULL there.
Comment #16
k.skarlatos commentedI checked with your latest change applied and it does not fix my problem.
I know it is a problem with the other module, but i think it is abandoned... :(
Comment #17
nancydruI couldn't even get it to not break Workflow.
Comment #19
m42 commentedSorry for re-opening this issue, but I wanted to tell everybody this would interest that I made a patch so that Workflow Fields should be compatible with latest releases of Workflow.
What I need now are testers and reviewers.
Any comment is welcome but, not to pollute this thread, let's do it in the appropriate page (where the patch is): #2057599: Patch to make Workflow Fields compatible with latest Workflow release (1.2)
Thank you very much for your help !
Comment #20
m42 commentedComment #21
k.skarlatos commentedthanks for the update, i will test and report back!
Comment #22
m42 commentedLadies and gentlemen, we're very proud to give to you the new beta1 release for D7 of the Workflow Fields module.
With many other corrections and improvements, this release makes Workflow Fields now compatible with Workflow 1.2.
That's it folks, now your reviews are welcome on the dedicated project page ! :)