If you browse by type, such that the url is:

/archive/blog

...and then click on "All" under the date in the Years row, you will now be searching all content types in addition to all years.

The problem comes from the fact that the "All" url is being given the url of 'archive' in the following code, however, all other links are sent through the _archive_url function which appends the /$type to the url.

 $output .= '<li'. ($date->year?'':' class="selected"') .'>'. l(t('All'), 'archive', array('title' => format_plural($all_count, '1 post', '@count posts'))) ."</li>\n";

To fix, simply change the line to:

 $output .= '<li'. ($date->year?'':' class="selected"') .'>'. l(t('All'),        _archive_url($type,NULL,NULL)             , array('title' => format_plural($all_count, '1 post', '@count posts'))) ."</li>\n";
CommentFileSizeAuthor
#1 patch.txt904 bytesSusurrus

Comments

Susurrus’s picture

StatusFileSize
new904 bytes

Try this patch. It doesn't pass NULL and NULL, just $date, as the second null is redundant and an object should be passed in for the second argument. If this works for you, then we're good to go.

Susurrus’s picture

This fix was incorporated into 5.x in the development branch. Try that and let me know if it works for you.

Susurrus’s picture

Status: Active » Fixed
SolomonGifford’s picture

Thanks:)

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.