So here's a starting point for the page and feed code.
The page is now a column sortable table with pagination. I'm not sold on the viability of this approach, but it's a start. Obviously not all the columns are needed, and we need to generate the tokenized message and have it, too.
As for the feeds, I propose that every module implements its own formatter for feed items, like this:
if (count($activities) > 0) {
foreach ($activities as $activity) {
$function = $activity['module']. '_format_rss_item';
if (function_exists($function)) {
// each module gets a chance to build its own feed item.
// They should use the $activity to prepare variables and
// call format_rss_item($title, $link, $item_text, $extra);
$items .= $function($activity);
}
}
}
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | patch.txt | 10.3 KB | robertdouglass |
| activity.patch | 8.45 KB | robertdouglass |
Comments
Comment #1
robertdouglass commentedMuch better patch that includes the menu and block fixes from other patches, plus a more aesthetically pleasing activity page.
Comment #2
sirkitree commentedimplemented this patch.
Comment #3
jlee commentedIs there a way to revert to the previous page layout, using the 5.3.x development branch?
Comment #4
jlee commentedalso.. trying to edit the "All Activity" feed menu item results in a Page Not Found error.
thanks
Comment #5
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.