While profiling some interactions in a theme, I've noticed that the current 7.x-1.x releases do not support XHProf symbols with slashes in their name.
For example, if a theme has a templates directory and renders "templates/page.tpl.php" in a theme function, some of the symbols that are output will include run_init::templates/page.tpl.php. Due to the way that the xhprof_display_page menu callback works, the extra information is passed to the function, but not as a named argument.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | xhprof-slashes-in-symbols-1975186-1.patch | 1.07 KB | Steven Merrill |
Comments
Comment #1
Steven Merrill commentedThe following patch adds support for symbols with slashes, both in the callback itself and in links that are generated on the pages where slashed symbols are displayed.
Comment #3
msonnabaum commentedI fixed this by just urlencoding the links. Simpler, and it seems to work fine.