Fixed database.mysqli.inc.patch to make it more generic and less prone to hunk failures

James Andres - December 4, 2007 - 00:46
Project:QueryCache
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:bnobleman
Status:closed
Description

Hello,

First, great module. Very useful!

I plan to use you're module on quite a large scale site so naturally I read over the patch before applying it. I notice two things, that my new patch fixes.

(1) You appear to be using some sort of an editor that automatically converts spaces to tabs for you. This behaviour goes against the PECL standards that Drupal uses for all core development. This caused your patch to be much larger than what was nesesary (many of the hunks were the same except the leading spaces had been converted to tabs)

(2) You applied you're patch to HEAD version of Drupal. This isn't a very good idea since most user's won't be running that version.

Thanks,

James.

AttachmentSize
database.mysqli.inc_.fixed_.patch2.16 KB

#1

bnobleman - January 15, 2008 - 23:17
Assigned to:Anonymous» bnobleman
Status:needs review» fixed

I've added it to the project

#2

Anonymous (not verified) - January 29, 2008 - 23:21
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.