Closed (fixed)
Project:
QueryCache
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
4 Dec 2007 at 00:46 UTC
Updated:
2 Nov 2013 at 00:30 UTC
Jump to comment: Most recent
Hello,
First, great module. Very useful!
I plan to use you're module on quite a large scale site so naturally I read over the patch before applying it. I notice two things, that my new patch fixes.
(1) You appear to be using some sort of an editor that automatically converts spaces to tabs for you. This behaviour goes against the PECL standards that Drupal uses for all core development. This caused your patch to be much larger than what was nesesary (many of the hunks were the same except the leading spaces had been converted to tabs)
(2) You applied you're patch to HEAD version of Drupal. This isn't a very good idea since most user's won't be running that version.
Thanks,
James.
| Comment | File | Size | Author |
|---|---|---|---|
| database.mysqli.inc_.fixed_.patch | 2.16 KB | James Andres |
Comments
Comment #1
bnobleman commentedI've added it to the project
-------
Bernard Szlachta
http://www.nobleprog.co.uk/drupal/training
http://www.nobleprog.us/drupal-training-courses
Comment #2
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.