Closed (fixed)
Project:
QueryCache
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
4 Dec 2007 at 00:53 UTC
Updated:
2 Nov 2013 at 00:30 UTC
Jump to comment: Most recent
Hello,
First, great module! Very useful!
I redid you're patch on database.mysqli.inc so that it: (1) uses less hunks, (2) conforms to the PECL standards for Drupal core patches, and (3) is patching against the current version of Drupal you're module supports (5.1.x) instead of HEAD.
PS: You should watch that you're editor doesn't convert spaces to tabs automatically. This doesn't conform to PECL / Drupal coding standards and also it makes your patches needlessly large. This can also cause hunk failures on some systems.
Thanks,
James.
| Comment | File | Size | Author |
|---|---|---|---|
| database.mysqli.inc_.fixed_.patch | 2.16 KB | James Andres |
Comments
Comment #1
James Andres commentedwhoops, i posted this 2x by accident. Please delete one of these two.
Thanks,
James.
Comment #2
bnobleman commentedPatched combined with other changed in new release
-------
Bernard Szlachta
http://www.nobleprog.co.uk/drupal/training
http://www.nobleprog.us/drupal-training-courses
Comment #3
bnobleman commented-------
Bernard Szlachta
http://www.nobleprog.co.uk/drupal/training
http://www.nobleprog.us/drupal-training-courses
Comment #4
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.