Hello,

First, great module! Very useful!

I redid you're patch on database.mysqli.inc so that it: (1) uses less hunks, (2) conforms to the PECL standards for Drupal core patches, and (3) is patching against the current version of Drupal you're module supports (5.1.x) instead of HEAD.

PS: You should watch that you're editor doesn't convert spaces to tabs automatically. This doesn't conform to PECL / Drupal coding standards and also it makes your patches needlessly large. This can also cause hunk failures on some systems.

Thanks,

James.

CommentFileSizeAuthor
database.mysqli.inc_.fixed_.patch2.16 KBJames Andres

Comments

James Andres’s picture

whoops, i posted this 2x by accident. Please delete one of these two.

Thanks,

James.

bnobleman’s picture

Assigned: bnobleman » Unassigned
Status: Closed (fixed) » Needs review

Patched combined with other changed in new release
-------
Bernard Szlachta
http://www.nobleprog.co.uk/drupal/training
http://www.nobleprog.us/drupal-training-courses

bnobleman’s picture

Assigned: Unassigned » bnobleman
Status: Needs review » Fixed
Anonymous’s picture

Assigned: Unassigned » bnobleman
Status: Needs review » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.