Download & Extend
QueryCache » Issues

Fixed database.mysqli.inc.patch to make it more generic and less prone to hunk failures

Posted by James Andres on December 4, 2007 at 12:53am
Project:QueryCache
Version:5.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:bnobleman
Status:closed (fixed)

Issue Summary

Hello,

First, great module! Very useful!

I redid you're patch on database.mysqli.inc so that it: (1) uses less hunks, (2) conforms to the PECL standards for Drupal core patches, and (3) is patching against the current version of Drupal you're module supports (5.1.x) instead of HEAD.

PS: You should watch that you're editor doesn't convert spaces to tabs automatically. This doesn't conform to PECL / Drupal coding standards and also it makes your patches needlessly large. This can also cause hunk failures on some systems.

Thanks,

James.

AttachmentSize
database.mysqli.inc_.fixed_.patch2.16 KB
Login or register to post comments

Comments

#1

Posted by James Andres on December 4, 2007 at 12:54am

whoops, i posted this 2x by accident. Please delete one of these two.

Thanks,

James.

#2

Posted by bnobleman on January 15, 2008 at 11:15pm

Patched combined with other changed in new release

#3

Posted by bnobleman on January 15, 2008 at 11:18pm
Assigned to:Anonymous» bnobleman
Status:needs review» fixed

#4

Posted by Anonymous (not verified) on January 29, 2008 at 11:21pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.