Fixed database.mysqli.inc.patch to make it more generic and less prone to hunk failures

James Andres - December 4, 2007 - 00:53
Project:QueryCache
Version:5.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:bnobleman
Status:closed
Description

Hello,

First, great module! Very useful!

I redid you're patch on database.mysqli.inc so that it: (1) uses less hunks, (2) conforms to the PECL standards for Drupal core patches, and (3) is patching against the current version of Drupal you're module supports (5.1.x) instead of HEAD.

PS: You should watch that you're editor doesn't convert spaces to tabs automatically. This doesn't conform to PECL / Drupal coding standards and also it makes your patches needlessly large. This can also cause hunk failures on some systems.

Thanks,

James.

AttachmentSize
database.mysqli.inc_.fixed_.patch2.16 KB

#1

James Andres - December 4, 2007 - 00:54

whoops, i posted this 2x by accident. Please delete one of these two.

Thanks,

James.

#2

bnobleman - January 15, 2008 - 23:15

Patched combined with other changed in new release

#3

bnobleman - January 15, 2008 - 23:18
Assigned to:Anonymous» bnobleman
Status:needs review» fixed

#4

Anonymous (not verified) - January 29, 2008 - 23:21
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.