Some file metadata (display, status, 3rd party operations, etc) does not make sense within the 'sort by' configuration field ... we need to provide a way for metadata to flag when it should not be included.

Comments

jthorson’s picture

Status: Active » Fixed
Issue tags: +project, +drupal.org D7, +testbot
jthorson’s picture

Status: Fixed » Needs work

extended_file_field.api.php needs a patch explaining this behaviour as well.

dww’s picture

Status: Needs work » Fixed

extended_file_field.api.php needs a patch for this one, too. Although, the API docs already claimed that the 'sort' key is optional. So, maybe instead of 'sort' => FALSE, we just want to remove the sort directive entirely? I guess it doesn't really hurt to explicitly say that sorting isn't allowed, so I guess we can leave this fixed, although it wouldn't hurt to clarify what sort => FALSE means in the docs...

Thanks,
-Derek

jthorson’s picture

Status: Fixed » Needs work

Crosspost?

dww’s picture

Yes, but I was just going to comment and leave it fixed, since I convinced myself that the PHPDocs are now accurate. If you want to explain what 'sort' => FALSE means, cool. Otherwise, you can set this fixed again.

Thanks,
-Derek

dww’s picture

ping? Can you explain what 'sort' => FALSE means in the docs? Seems like an easy fix to close this out.

Thanks!
-Derek

jthorson’s picture

Status: Needs work » Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 8de6ab5 on 7.x-1.x, empty-file-2150029 by jthorson:
    [#1976108] by jthorson: Allow metadata types to flag that they should...
  • Commit 14324e5 on 7.x-1.x, empty-file-2150029 by jthorson:
    [#1976108] Followup to explicitly describe sort=FALSE in the docblock.
    
  • Commit a25a4a4 on 7.x-1.x, empty-file-2150029 by jthorson:
    [#1976108] Followup to explicitly describe sort=FALSE in the .api.php...