That fails hard because then the job doesn't have a source language. This needs to be prevented with a validation error.

CommentFileSizeAuthor
#2 entity_sources_overview-1976530-2.patch5.51 KBsasanikolic

Comments

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Issue summary: View changes
Issue tags: +8.x release target
Related issues: +#1706630: Hide entity types with no translatable fields, +#2164041: Field gets translated eventhough it's not enabled for translation, +#2182085: Translatable nodes with empty translatable fields never go away from sources tab, +#2317891: "Language neutral" entities should not be translatable via the tmgmt_entity module

Check if relevant for 8.x.
Also adding some at least far related issues about wrongly showing "translatable" entities/fields.

sasanikolic’s picture

sasanikolic commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new entity_sources_overview-1976530-2.patch5.51 KB

Fixed the link of the source entity and the source entities with undefined source language are not displayed anymore.

sasanikolic’s picture

sasanikolic commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Closed (fixed)
Related issues:

I will work on porting the other issue, since this is already fixed in drupal 7.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Closed (fixed) » Closed (duplicate)
Related issues:

Misunderstanding :)

"The other issue" is #2317891: "Language neutral" entities should not be translatable via the tmgmt_entity module. Which is why I was confused btw, that one is adding validation.

And #2257375: Translate from a translation instead of the source language adds more.

Status: Closed (duplicate) » Needs work

The last submitted patch, 2: entity_sources_overview-1976530-2.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Closed (duplicate)