[D7] Password Confirm

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxpranit841976520git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Test your module at http://ventral.org/pareview/httpgitdrupalorgsandboxpranit841976520git

please checkout to new branch and remove master branch

There is still a master branch at http://drupal.org/project/1976520/git-instructions
Make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

Hi pranit84.

Manual reviw:

password_confirm.module
line 14
'label' => 'Password Confirm',
need add t() function

line 139

  if ($settings['encrypt_password']) {

need insert array_key_exists() function

line 46

 if ($settings['show_password']) {

need insert array_key_exists() function

Best regards.

password_confirm.module
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
49 | ERROR | else must start on a new line
52 | ERROR | else must start on a new line
--------------------------------------------------------------------------------

Hey,

A minor issue, but thought I'd document it anyway.

Description:
It is not possible to disable the module after creating and deleting a password field, until cron has run.

Steps to reproduce:
1. I installed the module, created a password field on the Article content type of a Vanilla Drupal install.
2. Created an Article with a value in the password field.
3. Deleted the password field from the content type.
4. Disable the module (via drush)

Actual result:
received the following message:
"password_confirm is a required module and can't be disabled. Reason: Fields pending deletion"

Expected result:
Module disables successfully

At this point I would assume I could disable the module since I've deleted the field and there are no more dependencies. Even checking "admin/reports/fields" before cron was run, the field did not show up in the field list.

Thanks for your contributions, pranit84! Nice module.

see #14

Removing review bonus tag, you have not done any manual review, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects, as requested on the review bonus page.

I removed the automated review comments from the issue summary.

removed automated reviews.

Hi Pranit,
I got an issue, while testing your module.

$form['pc'] = array(
    '#type' => 'password_confirm',
    '#title' => 'Title',
    '#default_value' => 'abc',
  );

this code generates an HTTP 500 error. If I change 'password_confirm' to 'password', it works. If I remove the '#default_value' line, it works.

cheers.

Pranit says:

Field type password confirm doesn't supports #default_value.

I know and I apologize, however it would be a good choice ignoring this mistake (see #password field)

Hi pranit84, please see some comments below:

When the 'Save Password in encrypted form' option is used (the default), there is no way of recovering the password. This could be confusing when used with the 'Show password' option, since it doesn't actually show the password but a salted, hashed version instead. Perhaps add a description on the field form or in README.txt to note this.

Since the form validates that both passwords are the same, there is no reason to store both copies of the password. Since a different salt is used, the hashed passwords can appear different but are still encrypting the same password. Without encryption, the two passwords are identical. I would suggest removing the second password field.

A couple of minor comment issues too:

password_confirm.module:9 This should be 'Implements hook_field_info().'
password_confirm.module:135: This should be 'Implements hook_field_presave().'

I've just spotted this module which seems quite similar, http://drupal.org/project/password_field have you seen this one before?

manual review:

1. Please describe the exact differences to password_field on the project page, so that users can make an educated choice between the modules.
2. "code modified" is not a useful git commit message, see http://drupal.org//node/52287

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to patrickd as he might have time to take a final look at this.

"code modified" is not a very good commit message - for sure you modified code - that's what a commit is all about.
Use the commit messages to describe WHAT and WHY you changed it. If there's an issue for the change begin the commit message with "Issue #[number]: [text]". (I just saw that klausi pointed that already out)

Beside that everything looks fine to me!

Thanks for your contribution!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.