[D7] Profile2 one page

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxcapynet1917766git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

I found an issue:

Why do you do this in profile2_one_page_form_user_profile_form_alter()?

<?php
if ($GLOBALS['user']->uid == 1) {
  return;
}
?>

In this way user/1 is not able to access the forms provided by profile2.

Let's talk about the require_once "profile2_one_page.admin.inc"; in the .module file:

Maybe you should move all your function implemented in profile2_one_page.admin.inc to the .module file. There are just hook implementations in profile2_one_page.admin.inc. Normaly there are form callbacks invoked by hook_menu(). So I think you don't need this extra file.

Very useful module. I installed it in a fresh drupal installation with last profile2 version and it works well, but I have some comments :

.info : don't forget to remove ;files[] = profile2_one_page.admin.inc

.module : l.118-119 you could remove comment.

- Empty User account fieldset appears when editing profile. It should not appear here. (see screenshot, it appears at the bottom of form).

- Profiles edit tabs still appear although your hook_menu_alter should disable them… I don't know if it will help you buth path to edit profile form looks like this in my installation (logged with authenticated user which user id is 2) :
/profile-main/2/edit (main profile)
/profile-test_profile/2/edit (test profile)
It seems that your access callback (.module l.17) is targeting other path.

Good luck!

I had disabled the module.
After reactivating edit tabs disappeared.
Clearing menu cache seems to have resolved the problem.
Here are the screenshots I took before.

Similar modules though they only have D6 versions:
https://drupal.org/project/account_profile - works with content_profile
http://drupal.org/project/onepageprofile - works with d6 core profile - and yours is called profile2_one_page

There does not seem to be a version for profile2. However, since profile2 is a direct descendant of Content Profile, I think you should try to join forces with Account Profile. Or do I have that reversed? I never remember which way it went. Does your module have other differences?

We prefer collaboration over competition, therefore we want to prevent having duplicating modules on drupal.org. If the differences between these modules are not too fundamental for patching the existing one, we would love to see you joining forces and concentrate all power on enhancing one module. (If the existing module is abandoned, please think about taking it over).

----
Top Shelf Modules - Enterprise modules from the community for the community.

Thanks capynet! If that fails for whatever reason please get back to us and set this back to "needs review".

I've added capynet as maintainer of Account Profile as the modules have similar approaches.

So should someone prefer Account Profile Module
to achieve what is mentioned in issue.