Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.This issue is a spin off of http://drupal.org/node/195781, where two references to a necessary cron task were 'standardized' so as to lead someone to the /admin/reports/status page (and referred to "Cron maintenance tasks").
I'll put a patch together a bit later in the day, most likely.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | cron-language-2.patch | 17.48 KB | keith.smith |
| #4 | cron-language.patch | 17.18 KB | keith.smith |
| #2 | cron-text.patch | 10.67 KB | keith.smith |
Comments
Comment #1
gábor hojtsyI usually say something meaningful instead of just writing subscribe, when I'd like to monitor an issue by mail, but this time I can only show my support :)
Comment #2
keith.smith commentedThis is a patch, but it still needs work. I'm posting it because I have to step out for a bit, and I want to preserve my work on this so far.
TODO:
-- modify system module's help text regarding cron
-- determine if any adjustment is needed to cron-related watchdog modules, etc
-- determine if any adjustment is needed to update module's cron-related text (I like the way update module does its text, and so have not yet modified it)
-- there may be a section or two in INSTALL.txt that needs to use this new wording
Comment #3
gábor hojtsyHm, stuff like
items indexed in a single <a href="@cron">Cron maintenance task</a>andItems to index per Cron maintenance taskdoes not look right to me. If we call the thing to configure the Cron maintenance task, we should not call one run of that thing we configured the same, should we?Comment #4
keith.smith commentedThe attached patch changes most other instances of cron (in like, aggregator, ping, search, etc) to use the "cron maintenance task" language. The language in search module and friends is not ideal, but the point in #3 is well-taken (this was just the best I've come up with so far).
This slightly modifies the INSTALL.php cron section to include a direct reference to the http://drupal.org/cron page, and also introduce this language.
This modifies any existing "Cron maintenance task" strings to "cron maintenance task".
This does not change any cron related watchdog calls, but I'm not sure that's desirable anyway.
This does not modify strings in, say, system.admin.inc that say "Cron ran successfully" or "Cron run failed". It does not modify strings in update module that refer to "run cron".
So -- and I realize that this was my idea -- this is one of those issues that I didn't think through well enough before beginning down this path. The style of referring to a "cron maintenance task" and linking to the status page works well for 95% of the instances where we use need to use it, but does not work well for the other 5%. This patch, while not ideal, brings us from about 50% conformity in this regard to about 95%.
Comment #5
gábor hojtsyThis would be great to fix soon :)
Comment #6
keith.smith commentedGábor: Did we cross-post?
Comment #7
gábor hojtsyYes, we did cross-post. Reviewing:
- IMHO the readme should have a few more examples on what does not work without cron, but that can even be done after string freeze
- "Items to index per cron run" was not modified to "Number of items to index per cron run" in the search.module help
Otherwise all looks good, a great improvement on the "Requires crontab" techy wizard language we had before the patch. Let's fix this remaining issues. Otherwise looks RTBC.
Comment #8
keith.smith commentedOk. Added additional language to INSTALL.txt and modified the search module help text to conform on the item description (which, was, by the way, a very good catch.)
Comment #9
gábor hojtsyThis one looks good, thanks, committed.
Comment #10
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.