New smackdown form shows up instead of voting page

Posted by colan on December 4, 2007 at 7:18pm

Issue Summary

Voting pages don't show up with the current logic, given that the output of array_rand() is used improperly. See http://ca.php.net/manual/en/function.array-rand.php for details.

If you are picking only one entry, array_rand() returns the key for a random entry.

Here's a patch. Please test!

Attachment	Size
smackdown.patch	476 bytes

Posted by colan on December 4, 2007 at 7:22pm

Title:

Improper use of array_rand()

» New smackdown form shows up instead of voting page

Posted by sirkitree on December 6, 2007 at 8:09pm

Status:

needs review

» fixed

Tested. Thanks!

Posted by Anonymous on December 20, 2007 at 8:12pm

Status:

fixed

» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.