Download & Extend

New smackdown form shows up instead of voting page

Project:Smackdown
Version:5.x-2.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:colan
Status:closed (fixed)

Issue Summary

Voting pages don't show up with the current logic, given that the output of array_rand() is used improperly. See http://ca.php.net/manual/en/function.array-rand.php for details.

If you are picking only one entry, array_rand() returns the key for a random entry.

Here's a patch. Please test!

AttachmentSize
smackdown.patch476 bytes

Comments

#1

Title:Improper use of array_rand()» New smackdown form shows up instead of voting page

#2

Status:needs review» fixed

Tested. Thanks!

#3

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here