Postponed
Project:
Edit Views
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Apr 2013 at 18:20 UTC
Updated:
3 Dec 2013 at 19:40 UTC
Jump to comment: Most recent
Currently views fields values are always wrapped into DIVs regardless whether a field was marked as "inline" in a row_style plugin.
Please consider this:
@@ -440,7 +440,9 @@ function edit_preprocess_views_view_field(&$variables) {
$edit_id = "$entity_type/$id/$field_name/$language/_custom_views";
- $variables['output'] = edit_wrap_pseudofield($variables['output'], $edit_id, _edit_is_extra_field($entity_type, $field_name));
+ $inline = in_array($variables['field']->field, $variables['view']->style_plugin->row_plugin->options['inline']);
+
+ $variables['output'] = edit_wrap_pseudofield($variables['output'], $edit_id, _edit_is_extra_field($entity_type, $field_name) || $inline);
}
}
}
Comments
Comment #1
Renee S commentedConfirmed, this has messed up a lot of my themes ! I was like "I was *sure* that was working..." ;)
One thing: the proposed fix doesn't work for table styled views, as there's no row plugin. For views, what's the harm in assuming all fields are inline when adding markup? If they're not, they'll have their own wrapper divs based on the style, and adding a span underneath that won't hurt anything. In that case I propose just sending edit_wrap_pseudofield() a TRUE for $is_inline.
Comment #2
wim leersPlease see #2149185: Figure out a way to *start* in-place editing inside a View — on a per-entity basis, just like elsewhere on the problems we need to solve before we can make Edit + Views integration a reality.
This issue is blocked on that issue.