Currently views fields values are always wrapped into DIVs regardless whether a field was marked as "inline" in a row_style plugin.

Please consider this:

@@ -440,7 +440,9 @@ function edit_preprocess_views_view_field(&$variables) {
 
       $edit_id = "$entity_type/$id/$field_name/$language/_custom_views";
 
-      $variables['output'] = edit_wrap_pseudofield($variables['output'], $edit_id, _edit_is_extra_field($entity_type, $field_name));
+      $inline = in_array($variables['field']->field, $variables['view']->style_plugin->row_plugin->options['inline']);
+
+      $variables['output'] = edit_wrap_pseudofield($variables['output'], $edit_id, _edit_is_extra_field($entity_type, $field_name) || $inline);
     }
   }
 }

Comments

Renee S’s picture

Confirmed, this has messed up a lot of my themes ! I was like "I was *sure* that was working..." ;)

One thing: the proposed fix doesn't work for table styled views, as there's no row plugin. For views, what's the harm in assuming all fields are inline when adding markup? If they're not, they'll have their own wrapper divs based on the style, and adding a span underneath that won't hurt anything. In that case I propose just sending edit_wrap_pseudofield() a TRUE for $is_inline.

wim leers’s picture

Title: Views edit field wrapper are always DIV » Views field wrappers are always <div>s
Project: Edit » Edit Views
Version: 7.x-1.x-dev »
Issue summary: View changes
Status: Active » Postponed

Please see #2149185: Figure out a way to *start* in-place editing inside a View — on a per-entity basis, just like elsewhere on the problems we need to solve before we can make Edit + Views integration a reality.

This issue is blocked on that issue.