Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 Apr 2013 at 22:21 UTC
Updated:
30 Apr 2013 at 22:43 UTC
Uses Smart IP module to see where your user is located.
Then dynamically displays an appropriate flag for the user's location.
It is very different from anything I've seen and didn't know why it would be such a hard project to put some flags on a screen. Well first you have to find the flags and the correct uses. Second, the only module I saw on Drupal that was D7 and easy to use was SmartIP. Then you have to learn a new software and all the terms, concepts, and very detailed graphic user interface with hundreds of buttons. Then create the flags. Load each one in (296 flags x 2 backgrounds x 2 types of graphics (jpg) and (gif)) and then create each file. After each one is rendered as still shots then they must be selected as a group to be animated. It took over 100 hours to render the still frames and then a separate process to animate them.
Drupal.org there are no
- flags that could be of logo size, but there are some pins and flavicons, but not any animated flags.
- logo modules that effect the logo directly. There are logos in blocks but most logo modules seem to be abandoned. I found out why. The reason is that it was difficult for me to grasp why the module couldn't effect the template and how to do it. I googled and looked and looked. I looked on every page about graphics and logos. After trial and error I almost had a break down at 2am in the morning when I discovered it. The preprocess and process code is what I discovered would work after a few days of trying different things.
My Information
- project page: http://drupal.org/sandbox/thomas_rendleman/1982846
- git clone http://git.drupal.org/sandbox/thomas_rendleman/1982846.git world_flag_logo
Thank you for your support,
Thomas Rendleman (thomas_rendleman)
| Comment | File | Size | Author |
|---|---|---|---|
| screen-shot-drupal.png | 583.19 KB | thomas_rendleman |
Comments
Comment #0.0
thomas_rendleman commentedJust updating.
Comment #0.1
thomas_rendleman commentedAdding reviews
Comment #0.2
thomas_rendleman commentedupdate reviews
Comment #0.3
thomas_rendleman commentedAdded more reviews
Comment #1
sreynen commentedComment #2
thomas_rendleman commentedSorry there was no comment on your post.
Comment #3
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxthomas_rendleman19772...
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3.0
PA robot commentedRewording. To make clear.
Comment #3.1
thomas_rendleman commentedMore minor corrections on wording.
Comment #3.2
thomas_rendleman commentedclearing up a few things.
Comment #4
thomas_rendleman commentedThe only errors I saw was when I tried to run your automated review. Please check and see what happened.
One time after submitting I got this error:
Error message
Sorry! There was an error during the process.
The other time this error
Submitted by Anonymous (not verified) on Wed, 04/24/2013 - 04:45
Git clone failed. Aborting.
Source: http://ventral.org/pareview - PAReview.sh online service
Hope I can see your automated review.
Thank you,
Thomas Rendleman
Comment #5
thomas_rendleman commentedHello is there someone that can give me a review?
The module takes time to download because it's large.
Please read the project page.
Comment #6
sreynen commentedLooks like the git repository is too large (likely because of all the image files) for ventral to run an automated review, so this will need to be manual review only. On a quick glance (not a full review), I see a few things work addressing:
1) you should move from master branch to a major version branch, i.e. 7.x-1.x, as you'll need to do that before creating a release
2) It's not clear to me why you're creating your own database table. It looks like you're only ever storing 1 row in that table, and you're loading it on every page load. That seems like a better use for variable_set() and variable_get().
3) However, #2 is only true if you're continuing to load the variable on every page load, which seems less useful than putting the output in a block so users can configure where and when it displays.
I'm leaving this as "needs review" because I haven't done a full review.
Comment #7
thomas_rendleman commentedThank you I am going to make some changed based on your comments. I appreciate the time to help a newbie. :)
Comment #8
thomas_rendleman commentedPlacing myself in a status of needs work while I change a few things.
Comment #9
pranit84It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
See http://drupal.org/project/1976520/git-instructions
Make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
Comment #10
thomas_rendleman commentedThank you pranit84,
I appreciate your help.
I am the new kid on the block and there is a lot of new things.
I need to go to an appointment but I am very excited about receiving your detailed message.
As soon as I get back I will certainly take full focus on it.
It really means a lot so Thank you
Comment #11
thomas_rendleman commentedHello pranit84,
Thank you for the advise. I was able to do everything with your help.
Comment #11.0
thomas_rendleman commentedmore small wording modifications.
Comment #11.1
thomas_rendleman commentedIncluded new branch information.
Comment #12
thomas_rendleman commentedI am placing this on hold. I needed to change 1 issue and until then I will not place this up on board for review.
Comment #12.0
thomas_rendleman commentedIncluded the branch from a non-logged in user looking at sandbox view.
Comment #13
thomas_rendleman commentedPlease take a look and review.
I fixed everything I could find.
Separated the graphics from the module for quicker downloads.
Please review.
Comment #14
thomas_rendleman commentedI removed the graphics from my module and it works with the automated review.
May I say "I AM IMPRESSED". It works great.
It has only one thing I don't know how to get rid of without making huge amounts of code.
FILE: /var/www/drupal-7-pareview/pareview_temp/world_flag_logo.admin.inc
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 3 WARNING(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
190 | WARNING | Only string literals should be passed to t() where possible
205 | WARNING | Only string literals should be passed to t() where possible
222 | WARNING | Only string literals should be passed to t() where possible
--------------------------------------------------------------------------------
Really this is super clean and I need some help reviewing. Thank you.
Comment #15
thomas_rendleman commentedFixed please disregard this module.
Comment #15.0
thomas_rendleman commentedNeed to update git information as I changed sandbox.