there is a style in node.css 

#node-admin-filter ul {
  list-style-type: none;
  padding: 0;
  margin: 0;
  width: 100%;
}

In D5 this style have removed a dot in "admin/content/node". Now this #node-admin-filter is missing and the dot is displayed in my theme. I saw Garland overrules this, but i don't understand why this <div id="node-admin-filter"> is removed!? This should be added back or i need to workaround around. :-(

CommentFileSizeAuthor
#12 before_patch.png52.67 KBJuliaKM
#12 after_patch.png23.49 KBJuliaKM
#10 node_filter_form_themeb.patch543 bytesdvessel
#7 node_filter_form_theme.patch543 bytesgdevlugt
#6 Picture 1.png88.51 KBdvessel
#4 node-admin-theme.patch1.85 KBjody lynn

Comments

hass’s picture

hass commented

Searched D6 for node-admin-filter, but this no more exist in code except the node.css.

jody lynn’s picture

jody lynn
she/her
Primary language English
commented
Version: 6.x-dev » 6.0-beta4

function node_admin_content() was changed in Drupal 6 and there seems to be a bug in it. The theme_node_filter_form is no longer being called - I think it is because drupal_get_form is no longer being used in that function.

jody lynn’s picture

jody lynn
she/her
Primary language English
commented
Title: #node-admin-filter ul missing in "admin/content/node" » Theming functions not called on node admin page
jody lynn’s picture

jody lynn
she/her
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new node-admin-theme.patch1.85 KB

The patch adds a theming function for node_admin_content to capture the theming of the form which was being missed.

dvessel’s picture

dvessel commented

Is theme_node_admin_nodes still being called? It looks like this removes that call.

-  $form['#theme'] = 'node_admin_nodes';

edit: never mind that. I see that you moved it to the new function.

dvessel’s picture

dvessel commented
Status: Needs review » Needs work
StatusFileSize
new Picture 1.png88.51 KB

See the pict. The results are out of control.

gdevlugt’s picture

gdevlugt commented
Version: 6.0-beta4 » 6.x-dev
Status: Needs work » Needs review
StatusFileSize
new node_filter_form_theme.patch543 bytes

Still a problem in D6 head. Attached is a simple patch for D6 head which works fine with the all (default D6) themes I tested it with.

gdevlugt’s picture

gdevlugt commented

Still a problem in D6 head. Attached is a simple patch for D6 head which works fine with the all (default D6) themes I tested it with.

Sorry for the triple post. Site was acting up weird.

gdevlugt’s picture

gdevlugt commented
Assigned: Unassigned » gdevlugt

Still a problem in D6 head. Attached is a simple patch for D6 head which works fine with the all (default D6) themes I tested it with.

Sorry for the triple post. Site was acting up weird.

dvessel’s picture

dvessel commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new node_filter_form_themeb.patch543 bytes

Visually, it made no difference in Garland but I verified that theme_node_filter_form is now being run.

Updated gdevlugts' patch due to fuzz..

jody lynn’s picture

jody lynn
she/her
Primary language English
commented

Nice. That was a whole lot simpler than I was making it.

JuliaKM’s picture

JuliaKM commented
StatusFileSize
new after_patch.png23.49 KB
new before_patch.png52.67 KB

Not sure if I'm doing something wrong, but when I apply the patch from #10, the list of nodes at admin/content/node vanishes. I'm using 6.x-dev. I've attached screenshots before and after applying the patch.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Needs review

Looks like a problem there.

catch’s picture

catch
he/him
Primary language English
commented

Applied #10, node listing appeared for me. Could do with a third person testing it I guess.

dvessel’s picture

dvessel commented
Status: Needs review » Reviewed & tested by the community

I don't think JuliaKM tested correctly.

JuliaKM’s picture

JuliaKM commented

dvessel is right. I downloaded Drupal again and applied the patch. This time it works! Sorry for the confusion.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Committed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.