Several of the node form content type plugins run the module name through t() by mistake. These are machine names and should not be translatable.

  $block->module = t('node_form');
CommentFileSizeAuthor
#1 1978350-1-ctools-block_module_t.patch7.22 KBpfrenssen

Comments

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Active » Needs review
StatusFileSize
new 1978350-1-ctools-block_module_t.patch7.22 KB
pfrenssen’s picture

pfrenssen
Location Sofia
commented
Issue summary: View changes

Clarified the problem.

DamienMcKenna queued 1: 1978350-1-ctools-block_module_t.patch for re-testing.

chris matthews’s picture

chris matthews commented
Issue summary: View changes

The 6 year old initial patch still applies cleanly to the latest ctools 7.x-1.x-dev, but still needs to be officially reviewed and tested by the community.

Applied patch plugins/content_types/node_form/node_form_attachments.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_author.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_book.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_buttons.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_comment.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_language.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_log.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_menu.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_path.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_publishing.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_title.inc cleanly.
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

Thanks for bringing this to my attention @Chris2, and for the patch @pfrenssen, I've committed this to the dev release.

  • joelpittet committed dcd67cc on 7.x-1.x authored by pfrenssen 
    Issue #1978350 by pfrenssen, Chris2: Do not translate $block->module...
pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Needs review » Fixed

Thanks for following up on this!

Something went wrong with the issue status, @joelpittet has set it to Fixed but it still appears as Needs Review right now. Trying to set it back to Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.