The URI for the favicon in the menu is <img class="admin-menu-icon" src="//domainname.com/sites/all/themes/mc/favicon@2x.ico" width="16" height="16" alt="Home">. I would expect it to be <img class="admin-menu-icon" src="http://domainname.com/sites/all/themes/mc/favicon@2x.ico" width="16" height="16" alt="Home"> (notice the missing "http:"

The icon has been custom set in /admin/appearance/settings to "sites/all/themes/mc/favicon.ico"

CommentFileSizeAuthor
#3 admin-home.png361 bytesAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented

I've run into this as well, with a broken favicon in the Home tab of the Admin menu. Not a show-stopper, but I don't like having broken things on sites!

I was able to add the "http:" to the URI by putting the following in template.php.

  function mytheme_admin_menu_icon($variables) {
    return '<img class="admin-menu-icon" src="http:' . $variables['src'] . '" width="16" height="16" alt="' . $variables ['alt'] . '" />';
}

It seems to correct the URI, but still leaves me with a broken favicon!

If anyone has a solution to this, it would be appreciated!

Alan

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

FYI: http://www.paulirish.com/2010/the-protocol-relative-url/

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new admin-home.png361 bytes

Sun, thanks for this, which I think explains what the Admin Menu is doing.

I had a further look at the module and documentation and took the route it recommends, which is to manage the icon directly, which I did using: 

function mytheme_admin_menu_icon($variables) {
  return '<img class="admin-menu-icon" src="' . path_to_theme() . '/admin-home.png" width="16" height="16" alt="" />';
    
}

along with the attached image that I dropped into my theme folder.

Job done, more learned and on with the work!

Alan

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
commented
Issue summary: View changes
Status: Active » Postponed (maintainer needs more info)
Issue tags: +postponed2w

I am sorry for no reply until now.

There are many issues regarding this module admin_menu which is a bit difficult for us to follow up since some of the issues might be already outdated, or is already fixed by the module or any other modules or itself core which means that the problem might no longer need to be fixed.

We can see that the issue has been created for a few years ago, I hope it is okay for you that I am postponing the issue, and give you around two weeks. If you still face the problem, could you tell us the step by step when until you get the error message or what is frustrated you, and a list of modules you are using related to admin_menu and a screenshot that might help us? So it makes us easier to reproduce your issue.

However, after two weeks with no feedback - we will close this issue. So in case, you noticed it after the issue is closed, do not hesitate to reopen it like and fill information which is mentioned above.

So before giving us a feedback, do you mind to test it again with our latest 7.x-3.x-dev?

Thank you for understanding! :)

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)
Issue tags: -postponed2w

This issue has been automatically marked as closed because it has not had recent activity after the last post.

However, if you or someone is still facing the same issue as described to the issue, could you please to re-open the issue by changing the status of the issue, and add an explanation with more details which can help us to reproduce your situation.

Again, thank you for your contributions.