Convert shortcut_link_add_inline to a Controller

Might be interesting.

#2: shortcut-1978970-2.patch queued for re-testing.

#2: shortcut-1978970-2.patch queued for re-testing.

#2: shortcut-1978970-2.patch queued for re-testing.

Reroll

+++ b/core/modules/shortcut/lib/Drupal/shortcut/Controller/ShortcutController.php
@@ -27,26 +39,58 @@ class ShortcutController implements ControllerInterface {
+      drupal_goto();

This function has been expunged. Return an appropriate redirect object instead.

Had to reroll anyway, the drupal_goto was swapped out for return new RedirectResponse(url('<front>', array('absolute' => TRUE)));

url()? No generator? Generator please. :-)

Yeah yeah :)

Taggin.

#12: shortcut-1978970-12.patch queued for re-testing.

Thank you. :-)

+++ b/core/modules/shortcut/shortcut.routing.ymlundefined
@@ -25,3 +25,10 @@ shortcut_set_edit:
+    _content: 'Drupal\shortcut\Controller\ShortcutController::addShortcutLinkInline'

_controller is probably enough, as we just redirect.

Made that change

Bot can disagree if it wants.

back to RTBC

Committed 4852362 and pushed to 8.x. Thanks!