Convert simpletest_test_form to a Controller

Hello

Attaching patch that converts simpletest_test_form() to a Controller.

Regards

Re-rolling improved patch.

Regards.

hi! Great job, thanks!
i think its good to go:)

#1978982: Convert simpletest_result_form to a Controller was committed first, so now we need to fix the @todo there

here it is

Great!

+++ b/core/modules/simpletest/lib/Drupal/simpletest/Form/SimpletestResultsForm.phpundefined
@@ -9,13 +9,12 @@
-class SimpletestResultsForm implements FormInterface, ControllerInterface {
+class SimpletestResultsForm extends SimpletestTestForm implements ControllerInterface {

I'm not sure that this is the right thing to do... and might turn out to be quite brittle... this kind of implies that the SimpletestResultsForm is a special case of the SimpletestTestForm and can share validator's etc... I don't think this is the case. For instance, if for whatever reason we add validation to SimpletestTestForm... then we'll have to add an empty validateForm() method to SimpletestResultsForm

I think in SimpletestResultsForm::submitForm() we should create a new instance of SimpletestTestForm and submit it.

I'm inclined to agree with Alex. This doesn't strike me as a "is a special case of" relationship.

That's indeed a good idea. Do you think this comment describes what we are doing?

Yep comment looks good to me... will leave for someone else to rtbc so I can commit :)

Get with the committing, dude!

Committed b8ddc39 and pushed to 8.x. Thanks!