I upgraded from 7.x-2.x and ran the updates. I have one invite type in the database for invite_by_email, but the Invite type select list is not populated on the Migrate page.

If I click on the Migrate button, I get the error, "Please choose an Invite type."

CommentFileSizeAuthor
#1 invite72xmigrate.patch793 byteselgordogrande
#2 invite-fix_migrate_form-1979144-2.patch2.72 KBoadaeh
#4 interdiff-1979144-2-4.txt573 bytesoadaeh
#4 invite-fix_migrate_form-1979144-4.patch3 KBoadaeh

Comments

elgordogrande’s picture

elgordogrande commented
Issue summary: View changes
StatusFileSize
new invite72xmigrate.patch793 bytes

The form select options conditional is testing for a string "invite_by_email" where it should be testing for existence in an array. Here is a patch that should resolve the issue.

oadaeh’s picture

oadaeh commented
StatusFileSize
new invite-fix_migrate_form-1979144-2.patch2.72 KB

Wow. It is amazing there aren't more comments on this rather critical issue.

The patch in #1 does indeed fix the problem. However, it no longer applies.

Also, there are a few other problems in that code:

  1. It checks if the controller is the correct type before checking if the module is even installed.
  2. If the invite_by_email invite type does not have the three required fields, it fails with a very uninformative notice.
  3. It requires that the Invite Notifications (invite_notifications) module be installed, even though it doesn't migrate that data.
  4. It drops the invite_notifications_2x table without migrating the data.

I've attached an updated patch that addresses the originally posted problem and the ones I listed here.

oadaeh’s picture

oadaeh commented
Status: Active » Needs review

Updating the Status.

oadaeh’s picture

oadaeh commented
StatusFileSize
new invite-fix_migrate_form-1979144-4.patch3 KB
new interdiff-1979144-2-4.txt573 bytes

I decided to add one more change: a notice on the page that it is possible to migrate the old data more than one time.