Add static caching to Twig_Environment::getTemplateClass()

I like this!

Pretty straightforward code, has benchmarks to back it up, theme system things are called like 1000 times, so effect will be even higher (more like 25-30 ms).

6 kB more vs 4-5 ms saved is a really pretty deal!

Comments are nice, tests still pass, can't think of anything else.

It is free performance, lets take it :-).

=> RTBC

+++ b/core/lib/Drupal/Core/Template/TwigEnvironment.phpundefined
@@ -110,4 +119,20 @@ protected function storage() {
+  /**
+   * Implements Twig_Environment::getTemplateClass().
+   *
+   * We override this method to add caching because it gets called multiple
+   * times when the same template is used more than once. For example, a page
+   * rendering 50 nodes without any node template overrides will use the same
+   * node.html.twig for the output of each node and the same compiled class.
+   */
+  public function getTemplateClass($name, $index = null) {

Needs to document the function params... and according the docs should be Overrides and not Implements...

Re-rolled, thanks for the help @alexpott

This function is overriding so inherit the documentation using {@inheritdoc}.

Is there an upstream issue/pr for this?

#6: 1979290-6.patch queued for re-testing.

Committed dced5e1 and pushed to 8.x. Thanks!

Obviously if the Twig PR lands we can rolls this back... nice work btw!

Just for your information, the patch has been just merged upstream.