Better S3 SSL support [#1979774]

When serving files from S3 via SSL there are a variety of scenarios where you end up with invalid certificate errors. For example, if your bucket has one or more dots in the name or you are using a CNAME alias.

Suggestion would be to fallback to the https://s3.amazonaws.com/[bucketname]/[object] format in this situation rather than failing to serve the content.

Patch coming in a sec.

Thanks...

Comment	File	Size	Author
#6	storage_api-1979774.patch	488 bytes	jonhattan
#2	storage_api-s3-ssl-1979774-2.patch	1.17 KB	jtolj
#1	storage_api-s3-ssl-1979774-2.patch	1.17 KB	jtolj

Comments

Comment #1

jtolj commented 25 April 2013 at 16:05

Status:

Active

» Needs review

Status	File	Size
new	storage_api-s3-ssl-1979774-2.patch	1.17 KB

And here is the suggested patch.

Comment #2

jtolj commented 29 April 2013 at 14:22

Status	File	Size
new	storage_api-s3-ssl-1979774-2.patch	1.17 KB

Sorry, mistake in the CNAME/SSL logic. Corrected patch attached.

Comment #2.0

jtolj commented 29 April 2013 at 14:22

Issue summary:

View changes

typo

Comment #3

perignon commented 9 October 2014 at 10:45

Assigned:	Unassigned	» perignon
Issue summary:	View changes

Good suggestion. I'll see about getting this added. The patch is no longer good because of other changes to the S3 provider that happened in the last few months.