Hi,

We have SSO enabled for our site, is there a way to disable "You have been successfully authenticated" when a user hits the site and authenticates using LDAP module?

I have Error message display turned to "none" in Drupal, but this does not seem to affect the text displayed when a user authenticates.

Our user sessions are destroyed/created whenever they close out of the site (close down their IE, and open it again).

I've searched the bug queue, but was unable to find anything related to this request.

Is this possible?

Thanks.

CommentFileSizeAuthor
#5 1980002-supress-successful-authentication-message-5.patch4.49 KBhaydeniv
#1 Capture.JPG19.52 KBc3rberus

Comments

c3rberus’s picture

c3rberus commented
StatusFileSize
new Capture.JPG19.52 KB

Attaching message image that we see.

c3rberus’s picture

c3rberus commented

Any change of an update on this?

johnbarclay’s picture

johnbarclay commented

I don't think this is generally desireable so not sure if it should be a feature. Here is a module to override strings: http://drupal.org/project/stringoverrides though I'm not sure what an empty string would produce.

haydeniv’s picture

haydeniv commented

I actually think the message should be suppressed by default. Drupal core does not notify you when you authenticate successfully. We could add a checkbox though to the SSO config if people still want the message. I have a project that I am currently working on that needs the message suppressed.

haydeniv’s picture

haydeniv commented
Status: Active » Needs review
StatusFileSize
new 1980002-supress-successful-authentication-message-5.patch4.49 KB

And the patch.

Bob_Vdl’s picture

Bob_Vdl commented

Thank you very much for the patch, works like a charm.

Will this be included in the next release?

haydeniv’s picture

haydeniv commented
Status: Needs review » Reviewed & tested by the community

Looks like this is good to go now.

13rac1’s picture

13rac1 commented
Status: Reviewed & tested by the community » Needs review

Sorry haydeniv. You can't RTBC your own work. I'm implementing this functionality today or tomorrow, so I can review.

haydeniv’s picture

haydeniv commented

I RTBC'd it because of this:

Posted by Bob_Vdl on May 29, 2013 at 4:23am

Thank you very much for the patch, works like a charm.

Will this be included in the next release?

But I'd be happy for a more thorough review. :)

13rac1’s picture

13rac1 commented
Status: Needs review » Needs work

It took a bit longer than I'd hoped to get this SSO all working. I used mod_auth_ntlm_winbind first, then discovered NTLM is deprecated and switched to mod_auth_kerb. It's all working now. Anyway...

I don't think we should change the module's existing functionality.

public $ssoNotifyAuthentication = FALSE;

As much as I want this notification disabled by default, someone else may have be expecting it. Two potential solutions:

  • Create a hook_update() to set this to TRUE for all existing sites.
  • Change the default to TRUE.
johnbarclay’s picture

johnbarclay commented
Title: Is there a way to supress "You have been successfully authenticated" message for SSO? » LDAP SSO: Is there a way to supress "You have been successfully authenticated" message for SSO?
Status: Needs work » Fixed

Thanks. I committed #5. Since its configurable it should be fine.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

c3rberus’s picture

c3rberus commented

This is great news, thank you.