It's not self-evident what a permission called "Administer content" includes.
I think it needs a description to explain its effects and how it differs from other similar permissions.
Come up with a good description. :)
N/A
N/A
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | node-administer-node-description-1980010-17.patch | 524 bytes | acabouet |
| #14 | nodes-administer-node-description-1980010-14.patch | 644 bytes | acabouet |
| #12 | node-administer-nodes-description-1980010-14.patch | 659 bytes | acabouet |
| #8 | Selection_002.png | 23.08 KB | giammi |
| #1 | node-administer-nodes-description-1980010-1.patch | 555 bytes | traviscarden |
Comments
Comment #1
traviscarden commentedMaybe something like "Perform administrative content operations such as promoting, changing ownership, and editing revisions across all content types."
Comment #2
izus commentedHi,
looks good for me.
Thanks
Comment #3
webchickMakes sense, but let's get some UX team review on this. This is a bit wordier than we tend to get on such descriptions.
Comment #4
xjm(Merging "node system" and "node.module" components for 8.x; disregard.)
Comment #5
shaundychkoI understand the desire to not be wordy, but I think it's important to list point by point everything this permission allows. Is "For all content types, this allows: promote to front page, change ownership, edit all revisions." the complete list?
Comment #6
interimblau commented1: node-administer-nodes-description-1980010-1.patch queued for re-testing.
Comment #7
interimblau commentedI have tested the patch and it works for me
Comment #8
giammi commentedTested the patch and works for me too. Added a prtscr.
Comment #9
catchStill needs usability review. We went through lots of permissions to remove the descriptions. I'm also not sure explicitly listing what this allows you to do helps - modules add other features that use this permission, or change the permission on those quite often.
Comment #10
selwynpolit commented1: node-administer-nodes-description-1980010-1.patch queued for re-testing.
Comment #11
Bojhan commentedThis should indeed be much more concise, take a look at the other permissions. We tend to start with the actions, we don't add "Perform administrative content operations". If needed add "and more" or "etc.".
Promote, change ownership, and editing revisions across all content types.
Comment #12
acabouet commentedUpdated the Administer content description to be less verbose: "Promote, change ownership, edit revisions, and perform other administrative tasks across all content types."
Comment #14
acabouet commentedSorry, trying that again. Looks like there was an issue with the patch filename.
Comment #16
acabouet commentedWeird! I'm not sure what I'm doing wrong. This patch is working for me locally.
Test log contains this error:
Output: [error: modules/node/node.module: No such file or directory].
Anyway, my proposed updated description: "Promote, change ownership, edit revisions, and perform other tasks across all content types."
Comment #17
acabouet commentedI figured it out! Just an error in the way I was generating the patch. Sorry for all the failed tests.
Comment #18
darol100 commented@acabouet,
I have test your patch on SimplyTest.Me and seem to be working fine.
Comment #19
alexpottCommitted c1a1735 and pushed to 8.x. Thanks!