Now that the Drupal 6 Betas are coming out, we have to consider updating the Services module to Drupal 6. Although getting it into core is in discussion for Drupal 7, we have to first update Services to Drupal 6.

CommentFileSizeAuthor
#9 services_d6_3.patch30.52 KBrobloach
#7 services_d6_2.patch31.36 KBmarcingy
#2 services_d6_1.patch24.57 KBrobloach

Comments

snelson’s picture

snelson commented

Hi Rob,

Its on my list ... somewhere. I would definitely like to have a D6 version ready when D6 is released. Will keep everyone posted.

Scott

robloach’s picture

robloach
he/him
commented
Status: Active » Needs work
StatusFileSize
new services_d6_1.patch24.57 KB

There are some menu and forms stuff that needs work, as well as validation that the services actually work. Any help greatly appreciated.

snelson’s picture

snelson commented

Rob, you rock.

Gonna test this out as soon as I can.

Thank you for your help!

robloach’s picture

robloach
he/him
commented

Hi Scott,

I was wondering if you needed a co-maintainer for the Services module? I could help out with both the reviewing and committing of patches, as well as with the maintenance of the Drupal 6 branch.

Thanks,

Rob

snelson’s picture

snelson commented

Rob, that would be awesome. I'd love to bring you on board -- I need the help. Tell me what your CVS name is and I'll add you.

robloach’s picture

robloach
he/him
commented

My CVS account name is (creatively) "robloach". Are there any things you'd like me to take a look at first? If not I'll have another hack at the Drupal 6 patch, and a quick look at the other two submitted patches.

marcingy’s picture

marcingy commented
StatusFileSize
new services_d6_2.patch31.36 KB

Improved version of patch for drupal 6.

There are still issues but it now reflects the usage of form_state and controlly applies access permissions to services.

However I think that following code:

foreach (module_implements('server_info') as $module) {
    $info = module_invoke($module, 'server_info');
    $items['services/'. $info['#path']] = array(
      'title' => 'Services',
      'access arguments' => array('access services'),
      'page callback' => 'services_server',
      'page arguments' => array($module),
      'type' => MENU_CALLBACK,
    );
  }

Needs to be moved into the indvidual server functions (and rewriten of course) otherwise the paths for any new servers won't be found because of the way the new menu system operates.

Alternatively the _enable function in each server install could call menu_rebuild.

snelson’s picture

snelson commented

Rob, you're good to go. I really appreciate your willingness to help out. Go ahead and dig into whatever you want.

Cheers,
Scott

robloach’s picture

robloach
he/him
commented
Assigned: Unassigned » robloach
Priority: Normal » Critical
Status: Needs work » Needs review
StatusFileSize
new services_d6_3.patch30.52 KB

The problem was that we needed hook_theme in there to theme the form for us. I fixed a couple of other things, including the menu route for the services. It now uses a dynamic argument to load the server, so we don't have to pass the menu handling to the server itself. There was also a small bug in hook_menu somewhere that was putting out an error that's now fixed.

It looks pretty good! The only issue I see now is that when you visit admin/build/services/browse/node.load, you don't see the active menu path (missing breadcrumb and services tabs). This shouldn't be something that holds back a release though, or sticking it into the CVS. Mind reviewing this a bit and making it RTBC if you want? I'll then stick it into HEAD.

marcingy’s picture

marcingy commented

I'll give it a go - I knew there were some issues as I basically got it into a working state last night and then ran out of steam!!

marcingy’s picture

marcingy commented
Status: Needs review » Reviewed & tested by the community

One issue. A notice is generated in xmlrpcs.inc

Trying to get property of non-object in C:\broker6\includes\xmlrpcs.inc on line 70.

However that is outside the scope of this patch. I'll roll a patch for that and submit to the issue queue for drupal 6 itself.

robloach’s picture

robloach
he/him
commented
Status: Reviewed & tested by the community » Fixed

Great work! I'll create the DRUPAL-6--1 branch soon.

robloach’s picture

robloach
he/him
commented

Thanks again, guys.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.