lockpick.js binds for locpick change don't respond if there was no original locpick marker [#1980340]

If you try to run a locpick change, but no original marker exists then the operation fails. Additionally there is no API method for testing if it exists, and no alternative method to create the first marker.

Additionally there is a flaw that if the original locpick_invalid is set to true, and a location is set, the system still thinks it is invalid.

The only inline solution is to duplicate the marker creation in the 'init' handler, and manually attach it to the obj. If we could extract that marker generation, and maybe put it in locpickchange, with a validation there, then things would be tested at the appropriate time, and external elements could safely trigger locpickchange.

I have a patch to submit.

Comment	File	Size	Author
#6	gmap-locpickrefactor-1980340-6.patch	5.54 KB	jaxxed
#1	gmap-lockpickmarkergenerationinlockpickchange-1980340-1.patch	3.33 KB	jaxxed

Comments

Comment #1

jaxxed commented 26 April 2013 at 09:47

Status	File	Size
new	gmap-lockpickmarkergenerationinlockpickchange-1980340-1.patch	3.33 KB

Here is a patch that:
- moves marker generation to the locpickchange event
- init uses lockpickchange
- locpick_invalid checked on locpickchange
- allow parameter position to lockpickchange (you can still manuallly set locpick_coord)