When not filing in any title it's still prints the wrapper tags. I guess this is only a problem with entities that not have a mandatory title field, like Fieldable panels panes.

CommentFileSizeAuthor
#13 dont-print-empty-wrapper-tags-1980520-13.patch1.89 KBpbz1912
#11 dont-print-empty-wrapper-tags-1980520-11.patch1.82 KBpbz1912
#2 dont-print-empty-wrapper-tags-1980520-2.patch474 bytesStoraH
#1 dont-print-empty-wrapper-tags-1980520-1.patch474 bytesStoraH
Empty tag.png8.49 KBStoraH

Comments

StoraH’s picture

StoraH commented
StatusFileSize
new dont-print-empty-wrapper-tags-1980520-1.patch474 bytes

Here is a patch that checks if the output is empty.

StoraH’s picture

StoraH commented
Status: Active » Needs review
StatusFileSize
new dont-print-empty-wrapper-tags-1980520-2.patch474 bytes

Status: Needs review » Needs work

The last submitted patch, dont-print-empty-wrapper-tags-1980520-2.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs work » Closed (duplicate)

Did you try the latest dev? This sounds like a duplicate of #1919640: Empty tag shown when the title field is displayed.

StoraH’s picture

StoraH commented

I did't try the latest dev version but that patch is in 7.x-1.0-alpha7 as well which I use.
To me they don't look related. The issue you linked to is for handel empty tags this is to handle empty output/title.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Version: 7.x-1.0-alpha7 » 7.x-1.x-dev
Status: Closed (duplicate) » Postponed (maintainer needs more info)

Please, try the latest dev anyway.

StoraH’s picture

StoraH commented

Ok, now I have tried the latest dev.. Still same problem.. It still prints wrapper tags even if there is no title.
And it should because it never checks if the title has a value. Once again this is not a problem with entities that have a mandatory title field, like nodes, but for Fieldable panels panes it is.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Postponed (maintainer needs more info) » Needs work

Ok, could you please provide a patch that can be applied to the dev branch? Thanks :)

StoraH’s picture

StoraH commented

Absolut :) I'll do it tomorrow.

StoraH’s picture

StoraH commented
Status: Needs work » Needs review

#2: dont-print-empty-wrapper-tags-1980520-2.patch queued for re-testing.

pbz1912’s picture

pbz1912 commented
StatusFileSize
new dont-print-empty-wrapper-tags-1980520-11.patch1.82 KB

The field was still being output in the render array in the other patch when the field was empty, this one should fix it. May need re-rolling.

Status: Needs review » Needs work

The last submitted patch, dont-print-empty-wrapper-tags-1980520-11.patch, failed testing.

pbz1912’s picture

pbz1912 commented
Status: Needs work » Needs review
StatusFileSize
new dont-print-empty-wrapper-tags-1980520-13.patch1.89 KB

Re-rolled against dev.

vincenzo’s picture

vincenzo commented
Status: Needs review » Reviewed & tested by the community

+1

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit c926482 on 7.x-1.x, workbench authored by pbz1912, committed by plach: 
    Issue #1980520 by StoraH, pbz1912: Fixed Empty wrapper tags.