Hello Jeremy,

I downloaded your dba module today and found it to be a great module.

Thank you for all your hard work on it.

I was playing around with it today and added functionality for doing a "Select All/Clear All" on the overview page to make it easier when someone wants to do a full database backup.

I thought you might want to take a look at it.

I was forced to use an attachment due to some security issue with displaying the code in Drupal.

See the attached file.

One thing though. In order to make it work I had to use a static value for each checkbox element name, as opposed to using the $table variable that you had.

If that is an issue please let me know, and I'll see if I can find a way to resolve that.

Thanks.

-Varr

CommentFileSizeAuthor
#4 check_clear_all.patch1.5 KBvarr
#1 Check_uncheck_0.doc6.06 KBvarr
Check_uncheck.doc5.92 KBvarr

Comments

varr’s picture

varr commented
StatusFileSize
new Check_uncheck_0.doc6.06 KB

Ok, so yes, replacing the element names with 'table' instead of $table, did in fact make a difference.

So I modified the code and now it works.

The modified code is in the attachment.

-Varr

jeremy’s picture

jeremy commented

Please resubmit as a patch (which should still be attached), not an rtf document. Then I will review what you have done.

robertdouglass’s picture

robertdouglass commented

can somebody turn this into a patch please? The code looks solid enough and it is a nice feature.

varr’s picture

varr commented
Assigned: Unassigned » varr
Status: Active » Needs review
StatusFileSize
new check_clear_all.patch1.5 KB

I finally got around to creating a patch for the check/clear all functionality.

Hope this helps.

-Varr

jeremy’s picture

jeremy commented
Status: Needs review » Active

Simple enough, although I couldn't get the patch to apply. (I finally did some cut and paste to test it out.) It works fine, however:
- the links should be added via dba_menu() as subtabs, they're hard to find at the bottom of the page.
- the names of the links should be lower case, to conform with all other links.

jeremy’s picture

jeremy commented
Status: Active » Fixed

I'm not sure you can make javascript subtabs from _menu(). Made minor changes, and applied the patch.

Thanks!

Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
jeremy’s picture

jeremy commented
Status: Fixed » Closed (fixed)

Manually closing, the project module doesn't seem to do this automatically anymore.