While it is good to have advertising functionality in feeds, controlling where the advertising comes from, YPN or others, belongs in other modules. I suggest collaborating with the maintainer of ad.module.

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Agreed. This has no place in this module. This belongs in an ad-type module that can alter the node object on rss building.

deekayen’s picture

deekayen commented
Status: Active » Fixed

Ad stuff was removed in cvs revision 1.31 a while back.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Fixed » Active

It's still in the DRUPAL-6--1 branch.

deekayen’s picture

deekayen commented

True, but I think it would be poor taste to yank functionality in the middle of a core state - that's why I figured it would just be gone as part of the D7 upgrade.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Meh, it's contrib, not core. :) If there's a better solution out there, why not remove it and add a drupal_set_message() that basically says "Hey sorry we removed this feature, but here's a way better module if you want this feature."

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Fixed

Removed from the DRUPAL-6--1 branch. Update message is provided if the feature was used directing people to ad.module (and sub-module ad_embed.module) or adsense_injector.module. Synced the HEAD update function with DRUPAL-6--1.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.