Advertising does not belong in atom.module
samirnassar - December 5, 2007 - 16:05
| Project: | Atom |
| Version: | 7.x-1.x-dev |
| Component: | Advertising |
| Category: | feature request |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
While it is good to have advertising functionality in feeds, controlling where the advertising comes from, YPN or others, belongs in other modules. I suggest collaborating with the maintainer of ad.module.
#1
Agreed. This has no place in this module. This belongs in an ad-type module that can alter the node object on rss building.
#2
Ad stuff was removed in cvs revision 1.31 a while back.
#3
It's still in the DRUPAL-6--1 branch.
#4
True, but I think it would be poor taste to yank functionality in the middle of a core state - that's why I figured it would just be gone as part of the D7 upgrade.
#5
Meh, it's contrib, not core. :) If there's a better solution out there, why not remove it and add a drupal_set_message() that basically says "Hey sorry we removed this feature, but here's a way better module if you want this feature."
#6
Removed from the DRUPAL-6--1 branch. Update message is provided if the feature was used directing people to ad.module (and sub-module ad_embed.module) or adsense_injector.module. Synced the HEAD update function with DRUPAL-6--1.
#7
Automatically closed -- issue fixed for 2 weeks with no activity.