All of the files making up this module have coding standards issues. Preferred action would be to provide a separate patch for each file in this issue. The spec is here: http://drupal.org/coding-standards. You should be able to automate issue detection with Coder, or use phpcs with the drupal standard in your text editor.

CommentFileSizeAuthor
#2 google_appliance-coding-standards-cleanup-1980910-2-7.patch18.26 KBdaluxz
#2 google_appliance-coding-standards-cleanup-1980910-2-4.patch4.6 KBdaluxz
#2 google_appliance-coding-standards-cleanup-1980910-2-3.patch13.75 KBdaluxz
#1 google_appliance-coding-standards-cleanup-1980910-1-7.patch18.15 KBdaluxz
#1 google_appliance-coding-standards-cleanup-1980910-1-6.patch796 bytesdaluxz
#1 google_appliance-coding-standards-cleanup-1980910-1-5.patch6.32 KBdaluxz
#1 google_appliance-coding-standards-cleanup-1980910-1-4.patch3.99 KBdaluxz
#1 google_appliance-coding-standards-cleanup-1980910-1-3.patch13.6 KBdaluxz
#1 google_appliance-coding-standards-cleanup-1980910-1-2.patch2.15 KBdaluxz
#1 google_appliance-coding-standards-cleanup-1980910-1-1.patch35.17 KBdaluxz

Comments

daluxz’s picture

daluxz commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new google_appliance-coding-standards-cleanup-1980910-1-1.patch35.17 KB
new google_appliance-coding-standards-cleanup-1980910-1-2.patch2.15 KB
new google_appliance-coding-standards-cleanup-1980910-1-3.patch13.6 KB
new google_appliance-coding-standards-cleanup-1980910-1-4.patch3.99 KB
new google_appliance-coding-standards-cleanup-1980910-1-5.patch6.32 KB
new google_appliance-coding-standards-cleanup-1980910-1-6.patch796 bytes
new google_appliance-coding-standards-cleanup-1980910-1-7.patch18.15 KB

Used the coder module and fixed most of the issues.
Every file in a seperate patch as requested.

The files are numbered like the following:

  1. testing/google_appliance.test
  2. testing/test-settings.example.inc
  3. theme/google_appliance.theme.inc
  4. google_appliance.admin.inc
  5. google_appliance.helpers.inc
  6. google_appliance.install
  7. google_appliance.module
daluxz’s picture

daluxz commented
StatusFileSize
new google_appliance-coding-standards-cleanup-1980910-2-3.patch13.75 KB
new google_appliance-coding-standards-cleanup-1980910-2-4.patch4.6 KB
new google_appliance-coding-standards-cleanup-1980910-2-7.patch18.26 KB

Rerolled 3 of the files to incorporate some extra fixes:

  • Removed some unused variables
  • Fixed a t()-function which contained variables
iamEAP’s picture

iamEAP commented

Thanks, @Daluxz! I'm reviewing and applying these one at a time. Basic idea is that git diff -w should return nothing, or if anything, only trivial differences.

Should get notifications for each commit, and I'll respond back with anything that may need work afterward. Hang tight!

  • Commit 0564516 on 7.x-1.x authored by Daluxz, committed by iamEAP: 
    Coding style clean up in google_appliance.test. [#1980910]

  • Commit 28893dd on 7.x-1.x authored by Daluxz, committed by iamEAP: 
    Coding style cleanup in test-settings.example.inc. [#1980910]

  • Commit 5002283 on 7.x-1.x authored by Daluxz, committed by iamEAP: 
    Coding style cleanup in google_appliance.helpers.inc. [#1980910]

  • Commit 3293660 on 7.x-1.x authored by Daluxz, committed by iamEAP: 
    Coding style clean up in google_appliance.install. [#1980910]

  • Commit 0e462ec on 7.x-1.x authored by Daluxz, committed by iamEAP: 
    Coding style clean up in google_appliance.theme.inc. [#1980910]

  • Commit 67dd533 on 7.x-1.x authored by Daluxz, committed by iamEAP: 
    Coding style cleanup in google_appliance.admin.inc. [#1980910]

  • Commit 1f2d2e3 on 7.x-1.x authored by Daluxz, committed by iamEAP: 
    Coding style cleanup in google_appliance.module. [#1980910]
iamEAP’s picture

iamEAP commented
Status: Needs review » Fixed

Thanks, again @Daluxz. Closing this issue, now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.