Problem/Motivation
Meta Issue: #1921610: [Meta] Architect our CSS
The BAT (base-admin-theme) file organization we started to do in Drupal 8 was a fantastic idea. See http://drupal.org/node/1089868
It works really well, but its names conflict with the SMACSS categorization we're using in Drupal 8. "base" and "theme" means something else in SMACSS. So we just need to rename them.
The Shortcut module does not yet follow the guidelines.
Proposed resolution
shortcut.base.css into css/shortcut.module.css
shortcut.base-rtl.css into css/shortcut.module-rtl.css
shortcut.theme-rtl.css into css/shortcut.skin-rtl.css
shortcut.theme.css into css/shortcut.skin.css
In addition, since our template files are now in a templates sub-directory of a module, we should do the same for the CSS. Note that the toolbar, tour and views modules already do that.
This is part of the CSS standard described at http://drupal.org/node/1887922
Remaining tasks
Needs manual testing - Test with this patch the CSS is being added to Drupal from its new location with its new name
User interface changes
none
API changes
The shortcut.module's CSS files will have new names.
By akmalfikri and Gomez_in_the_South
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | 1981054-shortcut-css.patch | 2.98 KB | akmalfikri |
| #10 | 1981054-shortcut-css-image-fix.patch | 7.94 KB | akmalfikri |
| #9 | after.png | 4.19 KB | dcam |
| #1 | 1981054-shortcut-cs.patch | 7.93 KB | akmalfikri |
Comments
Comment #1
akmalfikri commentedHere's the patch
Comment #2
gomez_in_the_south commentedI reviewed the patch in #1 and the CSS is being added to Drupal from its new location with its new name. It is RTBC from me, waiting for testbot to complete review.
Comment #3
johnalbinComment #4
shyamala commentedTagging
Comment #5
shyamala commentedadding novice tag
Comment #5.0
shyamala commentedChanged the naming convention
Comment #6
gomez_in_the_south commentedReviewed and tested.
Comment #7
shyamala commented@Gomez_in_the_South thanks for the testing!
Can you confirm what you reviewed, refer: http://drupal.org/node/1489010.
Please read http://drupal.org/node/1489010 for details on Manual testing.
check john's review at http://drupal.org/node/1981026#comment-7352628
Comment #8
shyamala commentedchanging status to needs review
Comment #9
dcam commented#1 needs work. The image URLs were not updated, e.g. changing "images/" to "../images/".
Otherwise, the patch looks good. I found no additional usages of the old CSS file names. The moved files are correctly being added to pages from their new /css directory.
Comment #10
akmalfikri commentedMy bad.
Here's the patch for #9
Comment #12
dcam commented#10: 1981054-shortcut-css-image-fix.patch queued for re-testing.
Comment #13
tim.plunkettPer #1921610-18: [Meta] Architect our CSS and further pushback against "skin", please do not rename .theme.css files to .skin.css.
Comment #14
akmalfikri commentedHere's the latest patch.
I have put the latest patch with the following amendments :
1. The correct git config as stated here : http://drupal.org/documentation/git/configure
2. Changed back .skin.css into .theme.css
Hope this is the correct one.
Comment #15
dcam commentedOk, I checked #14. It incorporates the changes from #9 and #13. I wondered what the deal was with the file deleting/adding instead of renaming. Anyway, #14 Looks good to me.
Comment #16
shyamala commentedCreated a single issue to rename all css files at: #1987066: Rename files to match CSS file naming convention based on request by webchick to make review easier. Thanks everyone on this issue, looking to your continued participation in the new issue.
Refer: http://drupal.org/node/1921610#comment-7375894
Comment #17
johnalbinSorry for the delay in reviewing these patches. My bronchitis flared up and I've been too sick until this week to get back into the issue queue.
Lots of discussions have happened in the interim. We just held a D8 Mobile Initiative meeting on Google+: https://plus.google.com/u/1/events/c0knva4lgh4vot0nun5lbfel9fc where we decided that we could make the CSS re-archicture work move faster by moving the work into a sandbox git repository. Then we could commit lots of little issues to the sandbox and roll larger, more-complete patches into Drupal 8’s issue queue. (per webchick's request)
So you're work is not lost! I'm moving this issue to the Mobile Initiative sandbox. :-)
Comment #18
johnalbinCommitted to the sandbox! :-)
Comment #20.0
(not verified) commentedAdded steps for manual testing