provide a workflow-ng action

I'm not very familiar with any of the workflow projects, but maybe this is a good excuse to learn. So basically, what we need to do is:

• Implement path_redirect_action_info describing path_redirect_action_create or something along those lines.
• Implement path_redirect_action_create, which would basically just call path_redirect_save with appropriate $form_values.
• Perhaps provide a configuration form for the action so you can choose a status code.

Does that sound about right? Does this all just get included in path_redirect.module, or does it make sense to put it in path_redirect_workflow.inc and only include that if the workflow module is enabled?

yep, that sounds right :) The .inc file makes perfectly sense.
You might want to have a look at the drupal_goto action of worklfow-ng: http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/workflow_ng...

You could start with that code. This action adds token integration so yours would also benefit from it!

I've started on this, but I'm having a little trouble seeing how the pieces fit together. I'd like to explain a hypothetical use case and see if this is the sort of thing I should expect to be able to do with Path Redirect + Workflow NG. Having a realistic test case will help me get this working correctly.

Say I'm moving a site from a bunch of static HTML pages into Drupal. I don't mind the busy work, so I'm going to recreate all these pages by hand. So what I used to have at:

http://example.com/projects/foo.html

...is now going to be at:

http://example.com/projects/foo

But I'd really like to have a URL redirect get created automatically for each of these pages since I don't have access to do this via mod_rewrite. Should I be able to set up a workflow that says:

When a node of type 'page' gets created with path 'foo/bar', create a new URL redirect from 'foo/bar.html' to 'foo/bar'.

So the net effect is that I can just go to node/add/page, create my page, and automagically get a path assigned via pathauto and a redirect created via the workflow. That would be nifty. Is that what workflow_ng should let me do?

Here's a very incomplete first stab at it. It does basically work as I'd expect, but I wasn't able to get the above scenario working. I'd end up with node/add/page.html instead of foo/bar.html. PEBKAC, probably.

Here's the configuration I was trying, for what it's worth.

the patch looks good.

@test case: I don't know the token [node:url], what is it about? Probably, it gives you back the wrong value.

-> You could need a token for the path alias of a node, I don't know if this is available somewhere. Instead you could try to rebuild the path with token replacements, however in a real world scenario this might create troubles due to the path cleaning of pathauto/workflow-ng. Anyway, I think a path alias token would make sense and allow both way to work cleanly.

You could also test the correct behavior just with a fixed path redirect string and creating only one node. If that works, it works with token replacements too :)

This version is working pretty well for me. I think you're right, fago; to do what I wanted, I would need a [node:alias] token which gave me the alias that was being assigned to the node that I'm creating. I may go ahead and commit this...

What's keeping you from committing this good patch? :)

Just letting it ripen. :)

I'm marking this fixed. If any bugs are found, new actions or conditions needed, or anything like that, please open a new issue!

Automatically closed -- issue fixed for two weeks with no activity.