When editing a term with multiple parents and one of those parents is the root, then the <root> option is not preselected in the parent terms select box. This can result in unexpected data loss if saving such a term without reselecting the root parent.

The reason is that taxonomy_term_load_parents() does not return parent=0 since this is not a "real term" that exists in the taxonomy_term_data table.

Note, that lib/Drupal/taxonomy/TermFormController.php has a special case for preselecting parent=0 if the term has no parents.

Steps to reproduce:

  1. Install Drupal
  2. Go to admin/structure/taxonomy/manage/tags/overview
  3. Add a term to be the parent
  4. Add another term and select both root and the other term as the relations
  5. Save
  6. See that your term is listed but at the root level and under the parent term
  7. Edit this term and save
  8. See that it is no longer at the root level
CommentFileSizeAuthor
#4 multiple-parents-quick-fix.patch829 bytesgielfeldt
#2 multiple-parents-quick-fix.patch828 bytesgielfeldt

Comments

gielfeldt’s picture

gielfeldt commented

On a personal note, I opt for removing support for multiple parents entirely...

gielfeldt’s picture

gielfeldt commented
Status: Active » Needs review
StatusFileSize
new multiple-parents-quick-fix.patch828 bytes

A very ugly quick-fix attached ...

The problem also seems to be present for D7 and D6.

Status: Needs review » Needs work

The last submitted patch, multiple-parents-quick-fix.patch, failed testing.

gielfeldt’s picture

gielfeldt commented
Status: Needs work » Needs review
StatusFileSize
new multiple-parents-quick-fix.patch829 bytes

Let's try again after rebasing.

gielfeldt’s picture

gielfeldt commented

Does anybody want to pitch in on this?

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Issue summary: View changes
Status: Needs review » Needs work

I think a change like this should have a test at the very minimum.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

pameeela’s picture

pameeela commented
Version: 8.9.x-dev » 9.3.x-dev
Issue summary: View changes
Issue tags: +Bug Smash Initiative

Still valid in 9.3.x

mohit_aghera’s picture

mohit_aghera commented
Related issues: +#2019905: TermStorage::loadParents() is missing the <root> parent from the returned list

This seems duplicate of https://www.drupal.org/project/drupal/issues/2019905
The other issue has more generic implementation considering forum module as well.

pameeela’s picture

pameeela commented
Status: Needs work » Closed (duplicate)

Agreed, thanks! This one is a bit older but I think you're right that the other one is more general so we should use that instead. I'll transfer credit over there.