Feed added on pages other than node view.

ragaskar - December 5, 2007 - 19:58
Project:Comment RSS
Version:5.x-2.x-dev
Component:Code
Category:bug report
Priority:minor
Assigned:Gábor Hojtsy
Status:closed
Description

Comment RSS is handling the drupal_add_feed logic in the menu system, which means that every URL beginning with node/$nid will get a comment feed link, whether it is appropriate or not. Example: editing a node results in a comment feed link appearing at the bottom.

The nodeapi hook seems a more logical place to execute this call; that way it can be limited to particular types of comment and only execute during a page view of the node in question.

There might also be an appropriate comment hook which would be useful for attaching the comment feed.

A simple (and not completely tested) fix for users who want the feed to appear only on a node view is to add arg(2)==NULL to the condition branch in the menu hook.

#1

Gábor Hojtsy - April 29, 2008 - 13:36
Version:5.x-1.x-dev» 5.x-2.x-dev
Assigned to:Anonymous» Gábor Hojtsy
Status:active» fixed

I have implemented the simple arg(2) == NULL check, which is fine as it is IMHO. It is in 5.x-2.x-dev, please try that and reopen if it is not a right fix.

http://drupal.org/cvs?commit=113501

#2

Anonymous (not verified) - May 13, 2008 - 13:42
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.