I upgraded to 1.9 and Superfish is working fine, but has disabled the Drupal javascript so WYSIWYG, shopping cart, all collapsible fields in admin interface aren't working.
If I disable the Superfish module, JS on the site functions normally. Unfortunately I don't know enough to debug this in any way.

I didn't back up the old module because I never altered it so I don't have a copy to restore :(
Is there anywhere I can get a copy of the previous version of the module just to get the site functioning properly?

Comments

mehrpadin’s picture

mehrpadin commented

Hey there,

Did you add the path to the sfsmallscreen.js too? (as explained nn the project page)

Also, you can always access all the releases here through the "View all releases" link, right beneath the downloads table.

Anonymous’s picture

Anonymous (not verified) commented

Hi Mehrpadin

Sorry for no feedback, I didn't get a notification of you reply. I couldn't add the path to sfsmallscreen.js as instructed at the time and couldn't understand why. Not adding that path does break the js

What I figured out after checking the library contents is that github is not supplying the correct download: sfsmallscreen.js is missing. When I copied and pasted that and uploaded it into the library, and followed the instructions, all is working as it should. I downloaded the library as a .zip file at github, so there's a problem with that.

Thanks for the tip on old releases.

Anonymous’s picture

Anonymous (not verified) commented

The usually reliable WinZip seems to be the culprit: the library is correct when I used 7-Zip to open it instead

webservant316’s picture

webservant316 commented

Same problem observed here.
The Drupal Superfish library needs to be simultaneously updated.
Get the code here "https://github.com/mehrpadin/Superfish-for-Drupal/zipball/master".
Install it here "sites/all/libraries".

mehrpadin’s picture

mehrpadin commented

Note that the 1.x branch of the library should be used for the v1.9, the master one is for the development releases (which I suggest everybody to use).

webservant316’s picture

webservant316 commented

please clarify...

what is the superfish library link for superfish 6.x-1.91?

or are you saying everyone should use the development release of the superfish drupal module and the master superfish library?

Anonymous’s picture

Anonymous (not verified) commented

My experience is that the 1.x branch of the library works fine with 6.x-1.91 if it is unzipped with 7-zip. Unzipping with WinZip causes missing js files

webservant316’s picture

webservant316 commented

I think you are saying use this

https://github.com/mehrpadin/Superfish-for-Drupal/zipball/1.x for superfish 6.x-1.91

instead of this https://github.com/mehrpadin/Superfish-for-Drupal/zipball/master

even though the README says to use the master.

Anonymous’s picture

Anonymous (not verified) commented

When I double-checked which one it is I'm using, it is the master version, sorry about that.

I have WinZip on my work machine, 7-zip at home, using different programs on the same files had a different effect. Whichever you use, what you need to check is:

  1. contents of library listed at github
  2. contents of library after unzipping the download
mehrpadin’s picture

mehrpadin commented

The Drush Make file too :) Sorry for the confusion, will update them soon.

mehrpadin’s picture

mehrpadin commented

Weird, perhaps something wrong with your WinZip settings? anyone else experiencing this?

webservant316’s picture

webservant316 commented

Ok back to using Superfish library https://github.com/mehrpadin/Superfish-for-Drupal/zipball/master with 6.x-1.91. All seems fine.

mehrpadin’s picture

mehrpadin commented

:) you should use the development release if you're using the master branch.

Anonymous’s picture

Anonymous (not verified) commented

I changed my library from master to 1.x branch and all is still working :).
I haven't changed any Win Zip settings & never had a problem before. I have no idea about that one, perhaps others can confirm it?

webservant316’s picture

webservant316 commented

Going back and forth here.
Ok switching back to the 1.x branch of the superfish library.
@mehrpadin you may want to update the README file to reflect this important fact.

mehrpadin’s picture

mehrpadin commented
Issue summary: View changes
Status: Active » Closed (works as designed)