Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
28 Apr 2013 at 12:54 UTC
Updated:
17 Sep 2013 at 22:25 UTC
DM User Picture Crop is a Drupal utility module based on jQuery that lets you crop your profile images when you upload them.
project page - http://drupal.org/sandbox/gansm/1969790
Link to repo - git clone http://git.drupal.org/sandbox/gansm/1969790.git dm_user_picture_crop
Comments
Comment #1
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxgansm1969790git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
gansm commentedI fixed few errors from the vental.org.
There are still errors, that are caused by third-party js and css.
Comment #3
markpavlitski commentedCan I suggest that you remove jquery.Jcrop.min.js from your module and use libraries instead? There are a number of other modules which also use Jcrop, so this would avoid conflicts.
You should switch to working on a 7.x-1.x branch, rather than master. See step-by-step guide here:
http://drupal.org/empty-git-master
Comment #4
gansm commentedChanged.
Currently I use libraries module.
Comment #5
gansm commentedComment #6
yury n commentedFirst of all please switch from master to working branch, as already noticed by markpavlitski.
In page--dmupc--empty.tpl.php file you should use an indent of 2 spaces, not tabs. Also please equalize indents.
In your javascript file dmupc.js isn't it better approach to use drupal behaviors instead of jQuery.(document).ready()?
Also you have a typo in dmupc.module at line 125
Comment #7
gansm commentedFirst of all please switch from master to working branch, as already noticed by markpavlitski.
changed
In page--dmupc--empty.tpl.php file you should use an indent of 2 spaces, not tabs. Also please equalize indents.
fixed
In your javascript file dmupc.js isn't it better approach to use drupal behaviors instead of jQuery.(document).ready()?
I don't believe it would improve or worsen the situation. The functionality is used only once and it seems like usage of drupal behaviors doesn't make much sense.
Also you have a typo in dmupc.module at line 125
fixed
Comment #8
kscheirerIt appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
It seems that there are many module that provide very similar functionality. Could you describe how your module differs?
We prefer collaboration over competition, therefore we want to prevent having duplicating modules on drupal.org. If the differences between these modules are not too fundamental for patching the existing one, we would love to see you joining forces and concentrate all power on enhancing one module. (If the existing module is abandoned, please think about taking it over).
Is it possible to apply for co-maintainership of Avatar Crop, and then release your version as the D7 release of that module?
----
Top Shelf Modules - Enterprise modules from the community for the community.
Comment #9
PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application.
I'm a robot and this is an automated message from Project Applications Scraper.