in views a condition fieldset appears (collapsed)
but choosing "hide if target field is empty/not empty" seems to try to get the TARGET drop down field but this nevere appears

Comments

swentel’s picture

Title: Appearing but not working in views » Views integration for ffc
Category: bug » feature
bharata’s picture

Category: feature » bug

I confirm that this is also happening in 7.x-1.0-beta2. Definitely a bug. No drop-down options appear. This blocks the use of my favorite option "use an event from rules" and any other setting requiring a drop-down.

bharata’s picture

The problem is only with the behavior of the options select box when you select a condition while initially setting up the filed. If you go through with this, even though things look broken because the further options don't appear, it works out. Just finish making all the selections that you want, then click "Apply". Now click on your field to re-open the settings... viola! The secondary select box is present and available.

bharata’s picture

Category: bug » feature

I didn't mean to overturn swentel's labeling of this as a "feature request". Changing it back.

Since accessing the configuration settings actually does work, I would say this is really just a request to either improve the interface so that it functions more intuitively or improve the documentation so new users expect to need to select "apply" and then re-open the field settings.

(The only issue I'm still having is that although the settings are configured, they don't take effect. I will start a new issue to discuss this.)

gonzalves’s picture

Issue summary: View changes

When I do this and return to the options, the target list is empty. No where am I able to find a patch and this is very critical for me..

alauddin’s picture

I am getting the same issue

Initially 'select a condition' - Save.

reopen the field dialog..Now the 'Select target field' shows up but with

using dev version and Views 7x -3.11

alauddin’s picture

I am getting the same issue

Initially 'select a condition' - Save.

reopen the field dialog..Now the 'Select target field' shows up but with - empty drop down

using dev version and Views 7x -3.11

nubeli’s picture

Category: Feature request » Bug report

I think it's pretty certain this is a bug. I too used the dev version of ffc and Views 3.

Chose "Hide when target field is not empty". Saved. Reopened the dialogue. The Select target field has an empty select element -- or to be more specific the select element doesn't have the correct options and no labels. The options should be fields in the View but are actually "node, user, comment, file, ...".

Probably related to this error:

Notice: Undefined index: label in ffc_get_condition_fields() (line 161 of /home/www/example/sites/all/modules/contrib/ffc/ffc.ffc_conditions_info.inc).

Softwar’s picture

Status: Active » Needs review
StatusFileSize
new1.12 KB

Hi everybody,

I had the same problem in my view. So I took few minutes to resolve this problem.

I created a patch to solve this problem.

Obviously, this patch helps to erase some errors like :

Notice: Undefined index: label in ffc_get_condition_fields() (line 161 of /home/www/example/sites/all/modules/contrib/ffc/ffc.ffc_conditions_info.inc).

but the condition field doesn't works more.

Now, I've an ajax error when I tried to select an option inside the fieldset... I don't have more time to research where is the problem.

If somenone has a solution, it'll be appreciated :)

ultrabob’s picture

I've confirmed that this patch at least lets me save my views, an improvement over ajax errors preventing me from removing the condition that was causing my view to break. I've not yet had a chance to test its effect on other places where it is used.

rootwork’s picture

Status: Needs review » Needs work

I can confirm that the patch fixes the errors, but since it also renders the conditions inoperable I think it's fair to say it still needs work...

Softwar’s picture

I think the question is, this settings is it really important ?

Because in views, each field gets the same configuration as managing display...

So in my humble opinion, this settings is useless in views...

My patch was to erase some errors nothing else.

So @rootwork you're right, we have to know if this setting is useful or not, and if not we still need to work more

rootwork’s picture

That's a good point. And conditions can largely be controlled in views through other means (such as arguments).

But the title of this issue is "views integration for ffc" -- this seems like basically a recommendation for "won't fix" with a patch to correct some errors.

Maybe that's the reasonable path forward. Others want to weigh in?

ultrabob’s picture

I agree that it would make sense to just make sure that this doesn't appear in or interfere with views. There are places where it would be convenient to have in views, but as @Softwar mentioned, there are ways to accomplish those things without this module. On the other hand, this module interfering with saving my views was a major problem.

zietbukuel’s picture

It seems this integration doesn't play well with Views Accelerator. If I turn on cache with this module, I get the following error:

Fatal error: Cannot use object of type DateObject as array in /var/www/html/mysite.com/public_html/includes/common.inc on line 6092