Caching mode bullet does not persist

It may be worse than that

it looks like it could be that the bullet doesn't show because cache doesn't get enabled AT ALL
I ran apache bench and results are same no matter what you choose

i get 13-15 requests per second (no matter which option i click)

Drupal 6.0B4
Path:/admin/settings/performance

OS: Red Hat Enterprise Linux AS release 4 (Nahant Update 4)
Server version: Apache/2.0.59
Server built: Feb 17 2007 06:24:55
PHP: PHP 5.1.6 (cli) (built: Feb 23 2007 06:56:38)
Zend Engine: v2.1.0
eAccelerator: v0.9.5
Xdebug: v2.0.0

anybody able to verify broken caching? b4 marking this as critical?

Duplicated on a clean install of D6 HEAD.

Marked http://drupal.org/node/198670 as a duplicate of this issue.

The problem is in the form implementation itself

In system.admin.inc on line 1187:

$form['page_cache']['cache'] = ...

And then on line 1258:

$form['clear_cache']['cache'] = ...

Both form items are using the same key 'cache'
So come form submit the clear cache button #value is overwriting the cache setting.

I think this may have been fixed by: http://drupal.org/cvs?commit=90561

Could you test with a fresh drupal cvs checkout and report back?

@Catch: this patch only fixes the CSS and JS compression radio... not the caching mode bullet.

@catch: I also duplicated it last night with a fresh CVS install (#3).

Quite trivial, but critical nonetheless.

So does renaming $form['clear_cache']['cache'] to $form['clear_cache']['clear'] solve the problem? Seems to be a logical solution.

Yes it does.

Look trivial, thanks, committed.