make (not verified) optional

+1

To what file should the patch drupal_not_verified_user.patch be applied?

I was confused for a moment. I see in the patch that it should be applied to includes/common.inc

+1

+1

Feature request go to cvs.

Bump.

I attach a different approach which allows the site administrators to enable or disable this using a theme setting.

I know from personal experience that many theme developers override the theme_username function to disable this which of course introduces issues when something changes on the theme_username function.

This is a regular request that should be incorporated into core.

I've tested this patch with an anonymous user that requires comment approval.

In the theme setting for Garland and the global theme settings, checking or unchecking "User verification status in comments" will always display "Anonymous" next to the comment display, whereas I would have expected to see "Anonymous" and "Anonymous (not verified)" depending on the theme settings. Is this by design? Because in the comment Preview it says "Anonymous (not verified)".

Also when configuring Drupal to accept comments without approval, for anonymous user I get this message displayed in plain HTML code:

<a href="/user/login?destination=comment/reply/1%2523comment-form">Login</a> or <a href="/user/register?destination=comment/reply/1%2523comment-form">register</a> to post comments

I am not entirely sure what you mean.

When I toggle the "User verification status in comments" in Garland it shows, or doesn't show, the "(not verified)" message on the comment approval queue, comment lists and on the node where the comment belongs too, so as far as I can tell it seems to work.

I also did not get any error when toggling the "Post comments without approval" permission.

That must mean that I forgot to clear the cache. I'll try again later.

Looks like that Drupal head is in part broken for the "(not verified)" message and the "Post comments without approval" permission, and this, without applying your patch.

I had to resort to a complete erase of my Drupal 7 and issue the CVS "cvs -z6 -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal co drupal". I also deleted the complete database and let Drupal recreate it as well.

So without the patch, the "(not verified)" message never show up. It does in fact show up only when an anonymous user preview his comment, though.

And without the patch, when I set the "Post comments without approval" permission, I get a Login or register to post comments. It's now properly formatted, no more HTML code.

These issues need to be resolved in D7 before I will be able to test your patch again.

I may need to post new bug issues about the "(not verified)" not showing up anymore and the "Post comments without approval" permission that does not let post comments.

What do you think?

#438224: "Post comments without approval" permission name is completely misleading have been created for the "Post comments without approval" permission issue.

#439148: login/register link generated when a user isn't allowed to comment, is transformed to html entities tackles the issues I had in #9 above.

From IRC : webchick: xmacinfo, Ok, you need to go to admin/build/types and enable the "Anonymou users may/must leave contact info".

I'll test the patch again.

Woohoo! RTBC at last with the help of #15.

Reloading the patch for the bot.

Set back to RTBC. We were waiting for a retest from the testing bot.

Committed to CVS HEAD. Thanks!