Download & Extend
Issues

make (not verified) optional

Posted by Anonymous (not verified) on April 1, 2005 at 8:23pm
Project:Drupal core
Version:7.x-dev
Component:user system
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

it would be nice to make the (not verified) flag for usernames optional,
module writers would set $additions['verified']=1 in hook_load() to remove it for
usernames that are not in the user databse, but still considerd verified.

AttachmentSizeStatusTest resultOperations
drupal_not_verified_user.patch580 bytesIgnored: Check issue status.NoneNone
Login or register to post comments

Comments

#1

Posted by Zach Harkey on November 13, 2005 at 6:14am

+1

#2

Posted by dtmatthes on March 29, 2006 at 11:46am

To what file should the patch drupal_not_verified_user.patch be applied?

#3

Posted by dtmatthes on March 29, 2006 at 11:56am

I was confused for a moment. I see in the patch that it should be applied to includes/common.inc

#4

Posted by bradlis7 on April 16, 2006 at 7:04pm

+1

#5

Posted by filiptc on August 30, 2006 at 1:47pm

+1

#6

Posted by LAsan on April 7, 2008 at 9:04am
Version:x.y.z» 7.x-dev

Feature request go to cvs.

#7

Posted by Gurpartap Singh on December 25, 2008 at 12:36pm

Bump.

#8

Posted by j.somers on April 13, 2009 at 7:11pm
Status:active» needs review

I attach a different approach which allows the site administrators to enable or disable this using a theme setting.

I know from personal experience that many theme developers override the theme_username function to disable this which of course introduces issues when something changes on the theme_username function.

AttachmentSizeStatusTest resultOperations
jsomers_19837_1.patch4.67 KBIdlePassed: 10923 passes, 0 fails, 0 exceptionsView details

#9

Posted by xmacinfo on April 19, 2009 at 2:59am
Status:needs review» needs work

This is a regular request that should be incorporated into core.

I've tested this patch with an anonymous user that requires comment approval.

In the theme setting for Garland and the global theme settings, checking or unchecking "User verification status in comments" will always display "Anonymous" next to the comment display, whereas I would have expected to see "Anonymous" and "Anonymous (not verified)" depending on the theme settings. Is this by design? Because in the comment Preview it says "Anonymous (not verified)".

Also when configuring Drupal to accept comments without approval, for anonymous user I get this message displayed in plain HTML code:

<a href="/user/login?destination=comment/reply/1%2523comment-form">Login</a> or <a href="/user/register?destination=comment/reply/1%2523comment-form">register</a> to post comments

#10

Posted by j.somers on April 19, 2009 at 8:26am

I am not entirely sure what you mean.

When I toggle the "User verification status in comments" in Garland it shows, or doesn't show, the "(not verified)" message on the comment approval queue, comment lists and on the node where the comment belongs too, so as far as I can tell it seems to work.

I also did not get any error when toggling the "Post comments without approval" permission.

#11

Posted by xmacinfo on April 19, 2009 at 11:44am

That must mean that I forgot to clear the cache. I'll try again later.

#12

Posted by xmacinfo on April 19, 2009 at 1:12pm

Looks like that Drupal head is in part broken for the "(not verified)" message and the "Post comments without approval" permission, and this, without applying your patch.

I had to resort to a complete erase of my Drupal 7 and issue the CVS "cvs -z6 -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal co drupal". I also deleted the complete database and let Drupal recreate it as well.

So without the patch, the "(not verified)" message never show up. It does in fact show up only when an anonymous user preview his comment, though.

And without the patch, when I set the "Post comments without approval" permission, I get a Login or register to post comments. It's now properly formatted, no more HTML code.

These issues need to be resolved in D7 before I will be able to test your patch again.

I may need to post new bug issues about the "(not verified)" not showing up anymore and the "Post comments without approval" permission that does not let post comments.

What do you think?

#13

Posted by xmacinfo on April 19, 2009 at 1:24pm

#438224: "Post comments without approval" permission name is completely misleading have been created for the "Post comments without approval" permission issue.

#14

Posted by xmacinfo on April 25, 2009 at 10:17pm

#439148: login/register link generated when a user isn't allowed to comment, is transformed to html entities tackles the issues I had in #9 above.

#15

Posted by xmacinfo on April 25, 2009 at 10:44pm
Status:needs work» needs review

From IRC : webchick: xmacinfo, Ok, you need to go to admin/build/types and enable the "Anonymou users may/must leave contact info".

I'll test the patch again.

#16

Posted by xmacinfo on April 25, 2009 at 10:51pm
Status:needs review» reviewed & tested by the community

Woohoo! RTBC at last with the help of #15.

#17

Posted by xmacinfo on April 25, 2009 at 10:57pm
Status:reviewed & tested by the community» needs review

Reloading the patch for the bot.

AttachmentSizeStatusTest resultOperations
jsomers_19837_2.patch4.67 KBIdlePassed: 10931 passes, 0 fails, 0 exceptionsView details

#18

Posted by xmacinfo on April 25, 2009 at 11:11pm
Status:needs review» reviewed & tested by the community

Set back to RTBC. We were waiting for a retest from the testing bot.

#19

Posted by Dries on April 26, 2009 at 9:14am
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks!

#20

Posted by System Message on May 10, 2009 at 9:20am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here