This is causing a problem with http://drupal.org/project/persona

CommentFileSizeAuthor
#3 neptune-sidebar-overflow-1983876-3.patch1.86 KBlaurencemercer
Screenshot from 2013-05-01 16:25:17.png10.45 KBjbrown
dont-hide-sidebar-overflow.patch981 bytesjbrown

Comments

laurencemercer’s picture

laurencemercer
Primary language English
commented
Status: Needs review » Needs work

Thanks for the report and patch.

overflow:hidden; is used as a layout fix for the <aside> containing the sidebars (because this collapses when there is a single column layout with two sidebars and the sidebars are floated), but it should be fine to remove overflow:hidden;, as you've already done, and then implement a different layout fix - possibly a clearfix.

I'll have a look.

jbrown’s picture

jbrown commented

Thanks!

laurencemercer’s picture

laurencemercer
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new neptune-sidebar-overflow-1983876-3.patch1.86 KB

The attached patch should resolve the issue. It removes overflow hidden, uses clearfix, and also updates the rtl CSS.

laurencemercer’s picture

laurencemercer
Primary language English
commented
Status: Needs review » Fixed

This is now fixed in the dev release.

jbrown’s picture

jbrown commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit a2b21dd on 7.x-1.x, 7.x-2.x by laurence_m: 
    Issue #1983876 by jbrown, laurence_m: Fixed sidebar overflow hidden.