From #1879676: Remove the issue # from the <title> to restore tab readability for some humans, I don't think that it's a good idea for project_issue to hard-code the HTML page title in project_issue_preprocess_html(). Tweaking the page title is very odd for a module to do because it means that I have to modify the theme in order to alter it effectively. And this isn't really an encouraged thing for modules to do (I cannot think of any modules that alter HTML titles for their own content). I think it would be better if the module supported a more appropriate way to tweak those page titles using either Meta tag or Page title. Metatag has an advantage in that it's configurations are exportable, so project_issue could ship with a default exported meta tag configuration for the instance node:project_issue.

Comments

dww’s picture

dww
we/he/they
commented

Generally, big +1 to this. The only concern is deploying something else on d.o. But, if the rest of the infra team is okay with it, I certainly am.

In the past, I've opened an issue in the infra queue asking if anyone's going to veto something. For example, folks were okay with RESTWS for issue JSON, but vetoed a dependency on Rules for trying to solve various things. So, it's not always a given. This might be a case where killes et al say: "screw that, we're not deploying a 64k (compressed) module on d.o to remove 4 lines of code from project_issue" (which is a good point). But, if there are other reasons we'd want to deploy one of those modules, I'm all for it...

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

If it proves to be ok to add another module to take care of this, then I think that of the two mentioned in the OP Metatag seems more useful to me. Page Title does have a slightly bigger user base, but it only solves a certain issue and that's it - no other benefits.

So, I guess it boils down to if we'll decide to simply add a module to address this specific issue alone or one that we could perhaps use later on for other things (SEO mainly) too.