[D7] Ubercart Donation Incentive

Hi deepaksrgm2010,

You're supposed to provide a link to the sandbox and git clone instructions in the issue description.

In addition to that you're supposed to have a 7.x-1.x branch instead of a master branch. This will ensure that the compatibility of your module is clearly indicated.

There are also some errors from pareview that you need to take care of http://ventral.org/pareview/httpgitdrupalorgsandboxdeepaksrgm20101982290git

Manual Review:

1. Several lines of commented code is present in "uc_donation_incentives.checkout_pane.inc" file. Remove it.
2. Indentation and other drupal coding standard needs to be followed. For details see: http://drupal.org/coding-standards
3. you are working in the "master" branch in git. User version specific branch. See: Moving from a master to a major version branch
4. In "uc_donation_incentives.admin.inc" line number 107, use t() function.
5. Write proper comments to describe functionality of each functions. Check: line number: 165-169 in "uc_donation_incentives.admin.inc".
6. Useless function like test() in .module file needs to be removed.
7. In 817 line of .module file use t() function for message.
8. Remove lines 11-18 from .info file.

deepaksrgm2010, make sure to change the status to "needs review" so everyone can see it's ready for review.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

It continues giving a lot of errors in http://ventral.org/pareview/httpgitdrupalorgsandboxdeepaksrgm20101982290git

Hallo deepaksrgm2010,
I install the Module and I get this errors in my node view and store reports page.

1. Node View Page
Undefined property: stdClass::$donation_incentive in uc_donation_incentives_node_view() (line 144 of uc_donation_incentives/uc_donation_incentives.module).
Trying to get property of non-object in uc_donation_incentives_preprocess_uc_donation_incentives_incentive() (line 444 of uc_donation_incentives/uc_donation_incentives.module).

You should check your data und provide defaults if this variable is not set to avoid errors:

function uc_donation_incentives_node_view($node, $view_mode, $langcode) {
  $weight = variable_get('uc_product_field_weight', array('donation_incentive' => 10,));
  $enabled = variable_get('uc_product_field_enabled', array('donation_incentive' => 0,));
  if (is_null($enabled)) {
    $enabled = "My Default data";
  }
  if (property_exists($node, 'donation_incentive')) {
    $node->content['donation_incentive'] = array(
        '#value' => theme('uc_donation_incentives_incentive', array('donation_incentive' => $node->donation_incentive, 'teaser' =>   0)),
        '#weight' => $weight['donation_incentive'],
        '#access' => $enabled['donation_incentive'],
    );
  }

2. Store Reports Page
Trying to get property of non-object in uc_donation_incentives_report() (line 120 of uc_donation_incentives.admin.inc).
Undefined property: stdClass::$uid in uc_donation_incentives_report() (line 162 of uc_donation_incentives.admin.inc).

• $results->fetchField() return from the database a single value. If you need an Object use $results->fetchObject()
• You are trying to access uid from the $account but you do not select the uid in the query.
  

  function uc_donation_incentives_report() {
  ...
  $query = db_select('uc_donation_incentives_orders', 'u');
  ...
  $query
        ->fields('u', array('id', 'order_id', 'rebated', 'purchased', 'status',))
        ->limit(10)
        ->orderByHeader($header)
        ->setCountQuery($count_query);
    $result = $query->execute();
  ...
  foreach ($result as $account) {
      $users_roles = array();
      $roles_result = db_query('SELECT rid FROM {users_roles} WHERE uid = :uid', array(':uid' => $account->uid,));
      // $account->uid: there is no uid in your select above.
      ...
      }
  

This is the link to your project page: https://drupal.org/sandbox/deepaksrgm2010/1982290.

You have a duplicate "a fixed amount, or a percentage of the sell price" on your project page.

Great README.txt file! You have some extraneous comments at the end of uc_donation_incentives.install.
In uc_donation_incentives.module you have some require_once statements in the global scope, that will add them to all Drupal page requests. Only load them when you need them.

An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.

You can find the results of the automated report at http://ventral.org/pareview/httpgitdrupalorgsandboxdeepaksrgm20101982290git. This project is hard to read and review until those are (mostly) fixed.

----
Top Shelf Modules - Enterprise modules from the community for the community.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

code tag added