Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Essential functionality may require additional google maps libraries:
1. encoding : polyline/polygon encoding and decoding is now handled inside the geometry library. This functionality is used inside the gmaps_shapes.js code.
https://developers.google.com/maps/documentation/javascript/libraries
Comment | File | Size | Author |
---|---|---|---|
#14 | gmap-libraries-1984912-14.patch | 943 bytes | jaxxed |
#12 | gmap-libraries-1984912-12.patch | 822 bytes | jaxxed |
#1 | gmap-googleapilibraries-1984912-1.patch | 855 bytes | jaxxed |
Comments
Comment #1
jaxxed CreditAttribution: jaxxed commentedHere is a patch to the gmap module that allows inclusion of google.maps libraries.
1. Insert libraries into googleapi call, which can come from 1 of 2 places:
variable_get('gmap_api_libraries',array())
gmap_module_invoke('libraries', $m)
2. inserted 'geometry' as a default library.
This relates to another patch of mine that updates te shapes library. If you want to use google api with encoded shapes such as lines or polygons that are encoded and ecoded at the JS level, then you'll need this library. There is an alternative option to use a custom encoding and decoding function set.
I don't know what priority this should be.
Comment #2
jaxxed CreditAttribution: jaxxed commentedComment #3
jaxxed CreditAttribution: jaxxed commentedComment #4
podarok#1 commited pushed to 7.x-2.x
thanks!!!
Comment #5
podaroktagged new beta release http://drupal.org/node/1987146
Comment #6
podaroktagged new beta release http://drupal.org/node/1987146
Comment #7
jaxxed CreditAttribution: jaxxed commentedPods: will you backport that to the 6.x line?
Comment #8
podarokre #7 if anyone create patch against 6.x-2.x-dev
Comment #9
jaxxed CreditAttribution: jaxxed commenteddo I just need to put the same patch, but applied to the d6 stuff? I can do that.
Comment #10
podarokre #9
yup, with proper statuses )))
Comment #11
jaxxed CreditAttribution: jaxxed commentedHey Pods, Is there a preferred method for warnings generated (at the javascript layer) for if a google.maps library is being called, but hasn't been loaded.
Unfortunately there is no lazy/late loading of the libraries, and each implementation will have to first check to see if the library namespace exists before using it. What reporting method would you prefer to use (right now the shapes library will silently fail if the library isn't loaded.)
Comment #12
jaxxed CreditAttribution: jaxxed commentedbackported to 6.x-2.x
Comment #13
podarokreturn array( 'geometry' );
No need for whitespaces
http://drupal.org/coding-standards#array
No need for
(array)
conversion), g
not
),g
everywhere
Comment #14
jaxxed CreditAttribution: jaxxed commentedformatting fixed (this is 7.x. 6.x patch is ready when you ask for it.)
Comment #15
jaxxed CreditAttribution: jaxxed commentedComment #16
podarok#14 commited pushed to 7.x-2.x-dev
thanks!!!